-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename a few properties in SearchIndexingBufferedSenderOptions #18285
Changes from 10 commits
03e83f6
4638d12
1b10182
09d278d
34a7066
6b41356
fac4ec4
b09aec9
fc74529
bdbab82
4f8c3cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ public class SearchIndexingBufferedSender<T> : IDisposable, IAsyncDisposable | |
/// The single publisher responsible for submitting requests. | ||
/// </summary> | ||
#pragma warning disable CA2213 // Member should be disposed. Disposed in DisposeAsync | ||
private SearchIndexingPublisher<T> _publisher; | ||
private readonly SearchIndexingPublisher<T> _publisher; | ||
#pragma warning restore CA2213 // Member should be disposed. Disposed in DisposeAsync | ||
|
||
/// <summary> | ||
|
@@ -108,15 +108,18 @@ public class SearchIndexingBufferedSender<T> : IDisposable, IAsyncDisposable | |
protected SearchIndexingBufferedSender() { } | ||
|
||
/// <summary> | ||
/// Creates a new instance of the SearchIndexingBufferedSender. | ||
/// Creates a new instance of <see cref="SearchIndexingBufferedSender{T}"/> that | ||
/// can be used to index search documents with intelligent batching, | ||
/// automatic flushing, and retries for failed indexing actions. | ||
/// </summary> | ||
/// <param name="searchClient"> | ||
/// The SearchClient used to send requests to the service. | ||
/// </param> | ||
/// <param name="options"> | ||
/// Provides the configuration options for the sender. | ||
/// The <see cref="SearchIndexingBufferedSenderOptions{T}"/> to | ||
/// customize the sender's behavior. | ||
Mohit-Chakraborty marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// </param> | ||
internal SearchIndexingBufferedSender( | ||
public SearchIndexingBufferedSender( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this still be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ...and if you're not calling the helper from tests anymore (at least, I don't see it here but maybe GitHub is hiding it), I'm puzzled as to why tests are now passing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Making it public is a part of the requested change. This is being used from the samples now. The helper is used heavily in the tests. That is the reason for the now small diff in BatchingTests.cs. |
||
SearchClient searchClient, | ||
SearchIndexingBufferedSenderOptions<T> options = null) | ||
{ | ||
|
@@ -131,9 +134,9 @@ internal SearchIndexingBufferedSender( | |
options.AutoFlushInterval, | ||
options.InitialBatchActionCount, | ||
options.BatchPayloadSize, | ||
options.MaxRetries, | ||
options.RetryDelay, | ||
options.MaxRetryDelay, | ||
options.MaxRetriesPerIndexAction, | ||
options.ThrottlingDelay, | ||
options.MaxThrottlingDelay, | ||
options.FlushCancellationToken); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't also remove the helper method on
SearchClient
?