-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data Plane SDK for Azure Remote Rendering #18159
Merged
Merged
Commits on Feb 5, 2021
-
Add the .net SDK for Azure Remote Rendering.
Project structure based on STS project. Use a link with the commit ID. Update project reference Temporarily work with a local swagger file. Add skeleton test files. Temporarily bring Authentication into solution. Rename Project change. Add temporary project dependency. Add some skeletal RemoteRenderingClient code. Add header Add some code for CreateConversion. First pass on c# generation. Don't use ConversionRequest. Service methods should be virtual. Target the correct json file. Add CreateConversionAsync Refactor test slightly Customize Conversion -> ConversionInformation. Customize "Error" -> "ErrorDetails" Reflect latest version of mr-arr.json Add wrappers for GetConversion and GetConversionAsync. Create session methods GetSession methods Update session methods Stop Session methods. Possible ListConversions implementation. ListSessions method. Fix comment. Async ConversionList and SessionList. Reorder methods Improve scopes. Add regions Add some tests. Use "x-ms-error-response": true to mark error responses. Slightly better sample. Add a session test. Take a dependency on the shared auth code. Improve customizations Generated code changes. Copy Azure Spatial Anchors approach to auth. Fix _accountId Copy some auth docs from ASA readme. Sample and test improvements Add some code snippets to readme. Take latest swagger with one tweak (added , "x-ms-error-response": true to ListConversions) Update generated code. Adapt client to new code. Pass options to rest client. Take latest mr-arr.json Fix test Sample improvements. Take a package dependency on Auth instead of a project reference. Fix version string. Move solution into subfolder. Add basic pipeline defs. Fix pipeline issues. GUID for IDs. Fix link. Showing what ConversionOperaiton would look like. Reference the swagger file externally. Take the serviceUri into the client constructor. CreateConversionSettings should be internal. ConversionList and SessionsList can be internal. Tweaks. Add small tweaks on testing. Adapt tests. Make GetConversion internal Remote an unneeded method Remote another uneeded method. Adapt samples and tests to LRO Restore GetConversion. Extra assert. Constructor parameters. ConversionSettings -> ConversionOptions. ListConversions -> GetConversions. Same with sessions. Capitalization in version segment Signature Change signature Customize ConversionInputOptions and ConversionOutputOptions. StorageContainerUri is now a Uri. Change several members of ConversionInformation. Don't take an AuthenticationEndpoint as constructor argument. ErrorDetails -> ConversionError Customize Conversion -> AssetConversion. Update generated files. SessionProperties -> RenderingSession SessionStatus -> RenderingSessionStatus StartSessionOperation -> StartRenderingSessionOperation RenderingSession.Id -> RenderingSession.SessionId InputLocation -> InputOptions & same for output. Take latest swagger file. Since the client requires accountId to be a guid, it's better to check it up front. Throw exception. Make some properties get only. Comment. Remove accidental property. CreateSessionSettings -> RenderingSessionOptions Hostname -> Host. The Error class is common to conversion and rendering. SessionSize -> RenderingServerSize Use TimeSpan in API instead of minutes. CreationTime -> CreatedOn UpdateSessionSettings -> UpdateSessionOptions. Don't need Models in Model namespace. ListConversions -> GetConversionsAsync No need for setters on required properties. UpdateSessionOptions should use TimeSpan. Full stop. test-resources now creates an ARR account. Create storage account in ARM. Create a blob container from ARM. Copy test asset to new blob storage Test improvements. Bite bullet and share testing resources with rest of mixed reality. There seemed to be built-in assumptions about SDK location used when setting environment variables. Create a SAS token and use it in tests. Fix conversion test. Use an ordinary enum for AssetConversionStatus. RenderingSessionStatus is now an enum. Reorder enums Revert "Reorder enums" This reverts commit 52001e01f08d5f6c1acaefb5b44b746dce3cdf5e. Revert "RenderingSessionStatus is now an enum." This reverts commit 2cc11f4a3eef0425d8115b7ec5f93a537e7a6f60. Revert "Use an ordinary enum for AssetConversionStatus." This reverts commit 6a83477c1d7f5f1f076455257573afe1ba67ba41. Don't need a remote rendering folder. Rendering session test. Fix diagnostic scope problem, and add recordMatcher (with no contents) Golden path tests for conversion. Add test traces for session creation. Remote hard-code test mode. Use basename for storageAccountName. Add failed tests and better session recordings. Better test. Add async test recordings. Don't need a recordMatcher. Better commented code. Test environment improvements. Remove a todo. Prevent the samples being run in the tests. Construct an explicit ARR end-point. Readme and sample improvements. README improvements. README improvements.
Configuration menu - View commit details
-
Copy full SHA for 33b303b - Browse repository at this point
Copy the full SHA 33b303bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79882d0 - Browse repository at this point
Copy the full SHA 79882d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a273fbf - Browse repository at this point
Copy the full SHA a273fbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6dc15a - Browse repository at this point
Copy the full SHA b6dc15aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e07fbdb - Browse repository at this point
Copy the full SHA e07fbdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbeb762 - Browse repository at this point
Copy the full SHA cbeb762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57da534 - Browse repository at this point
Copy the full SHA 57da534View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1407fe0 - Browse repository at this point
Copy the full SHA 1407fe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76084bf - Browse repository at this point
Copy the full SHA 76084bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7e3ff - Browse repository at this point
Copy the full SHA 4e7e3ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2261308 - Browse repository at this point
Copy the full SHA 2261308View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ed34c2 - Browse repository at this point
Copy the full SHA 5ed34c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd800d - Browse repository at this point
Copy the full SHA bfd800dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 555b0c4 - Browse repository at this point
Copy the full SHA 555b0c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb13b78 - Browse repository at this point
Copy the full SHA fb13b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for de74366 - Browse repository at this point
Copy the full SHA de74366View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f7bfa6 - Browse repository at this point
Copy the full SHA 6f7bfa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01021fc - Browse repository at this point
Copy the full SHA 01021fcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.