Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SecurityInsights SDK [preview2] #17969

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Update SecurityInsights SDK [preview2] #17969

merged 5 commits into from
Jan 21, 2021

Conversation

dicolanl
Copy link

@dicolanl dicolanl commented Jan 14, 2021

  • Swagger review PR(s) link in PR description, and the PR(s) is merged
    Fixed the operationId of get/put/delete action azure-rest-api-specs#12415
  • Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
  • Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
  • Release notes in *.csproj is updated
  • If there's a API-version update, the API tags in Az.Sdk.props are updated
  • Generated code is not touched
  • Proper test coverage

-Regenerated code using latest API.
--API - added teams to OfficeDataConnector
-Updated strings in tests
-Recorded new test sessionrecords

-Regenerated code using lastest API.
-Updated strings in tests
-Recoreded new test sessionrecords
@allenjzhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@allenjzhang
Copy link
Member

/azp run net - mgmt - ci (Build)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@allenjzhang
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bquantump
Copy link
Member

Please look into fixing the CI or we will close this.

@dicolanl
Copy link
Author

hi @bquantump
I tried pinging @allenjzhang on teams and didnt get a reply. I dont understand why the error is occuring?
i used autorest to generate the code. I only changed my test code and test recordings. Why is it saying there is manually entered code when i didnt manually enter anything?

@dicolanl
Copy link
Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 17969 in repo Azure/azure-sdk-for-net

@dicolanl
Copy link
Author

@bquantump ran generate.ps1 looks like the pipelines finished successfully now

@bquantump
Copy link
Member

Updated assembly versions and release notes
@dicolanl
Copy link
Author

@bquantump Done added the check list to the initial PR and ensured each step is completed.

@bquantump
Copy link
Member

/check-enforcer evaluate

@bquantump bquantump merged commit bfeefde into Azure:master Jan 21, 2021
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
* Added teams to sdk from API

-Regenerated code using lastest API.
-Updated strings in tests
-Recoreded new test sessionrecords

* Ran generate.ps1

* Update tests due to api changes

* Version Update

Updated assembly versions and release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants