[Communication] - SMS - Managed Identity Support for SMS Client #17867
Conversation
minnieliu
requested review from
ankitarorabit,
DominikMe,
KrzysztofCwalina,
RezaJooyandeh,
tg-msft and
a team
as code owners
ghost
added
the
| @@ -36,6 +36,14 @@ string connectionString = "YOUR_CONNECTION_STRING"; // Find your Communication S | |||
| SmsClient client = new SmsClient(connectionString); | |||
| ``` | |||
|
|
|||
| Alternatively, SMS clients can also be authenticated using a valid token. | |||
There was a problem hiding this comment.
Should we tell users to have their client id, tenant and client secret as env variables for DefaultAzureCredential to work?
There was a problem hiding this comment.
Done, thanks for the suggestion Jorge!
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## 1.0.0-beta.4 (Unreleased) | |||
|
|
|||
| ###Added | |||
| - Support for creating PhoneNumberAdministrationClient with TokenCredential | |||
There was a problem hiding this comment.
Great catch!! Thank you, I've fixed this
@ankitarorabit Just checked with Jorge. We cannot record tests for AAD right now because that Prague team is blocking us. We will be able to record and do playback tests after we are unblocked. |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run net - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…nto managedIdentitySms
|
/azp run net - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Draft for now: Blocked on running the Live tests for Managed Identity support for SMS. Waiting for service team to enable this functionality and should be available after Jan 15th.
SMS also has some additional complexity because it uses static resources in the live tests. For now, I have skipped the implementation of new live tests for managed identity until we have a solution going forward.