Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InheritDoc conditional logic #17774

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

christothes
Copy link
Member

This may be related to IDT001 errors surfacing in builds despite the following statement

https://github.com/Azure/azure-sdk-for-net/blob/master/eng/Directory.Build.Data.props#L76-L80

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine although I wouldn't expect adding the space to change the condition in msbuild.

@christothes
Copy link
Member Author

The change looks fine although I wouldn't expect adding the space to change the condition in msbuild.

There have been some flakey build failures that could be related, so I thought it wouldn't hurt just to eliminate it as a possibility.

@christothes christothes merged commit a0cccce into Azure:master Jan 5, 2021
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants