Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local swagger and re-record #17753

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

christothes
Copy link
Member

Fixes #16510

@christothes christothes self-assigned this Jan 4, 2021
@ghost ghost added the Tables label Jan 4, 2021
@christothes christothes added the Client This issue points to a problem in the data-plane of the library. label Jan 4, 2021
### Fix Response type for QueryEntitiesWithPartitionAndRowKey

``` yaml
directive:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tracked anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of - Azure/azure-rest-api-specs#10194 (comment)

I need to follow up on that PR though as it aged out over the break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and opened a new PR for this change.
Azure/azure-rest-api-specs#12280

@check-enforcer
Copy link

check-enforcer bot commented Jan 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@christothes
Copy link
Member Author

/azp run net - tables - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christothes
Copy link
Member Author

/azp run net - tables - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christothes christothes merged commit 0d90c47 into Azure:master Jan 5, 2021
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
* remove local swagger and re-record

* short circuit ignored test setups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the autorest.md file to use swagger README instead of json file
2 participants