Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Exclude Legacy Packages from Pipelines #17659

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Dec 21, 2020

Summary

The focus of these changes is to remove the legacy packages from the build pipeline definitions, as they're now covered under a dedicated set of pipeline definitions. This is intended to allow the T1 and T2 Event Hubs packages to be treated as separate units of work, as they will continue to evolve independently
and are maintained by different teams.

Note: This set of changes depends on #17658, which should be committed and validated first. In addition, the new T1-centric pipeline definitions should be created prior to merging these changes.

Last Upstream Rebase

Monday, December 21, 11:55am (EST)

References and Related

The focus of these changes is to remove the legacy packages from the
build pipeline definitions, as they're now covered under a dedicated set
of pipeline definitions.

This is intended to allow the T1 and T2 Event Hubs packages to be treated
as separate units of work, as they will continue to evolve independently
and are maintained by different teams.
@jsquire jsquire added Event Hubs Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Dec 21, 2020
@jsquire jsquire added this to the MQ-2020 milestone Dec 21, 2020
@jsquire jsquire self-assigned this Dec 21, 2020

extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: eventhub
ExcludeProjects:
- Azure.ResourceManager.EventHubs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard should be sufficient, but there's one outstanding observation from the initial round of testing where it's not 100% confirmed for one of our script calls.

My approach here was to explicitly define everything that exists today and leave the wild card to provide some level of filtering for anything new. I'm still working with members of the engineering team to investigate and will open a new PR to trim to just the wild card, if possible.

Copy link
Member

@christothes christothes Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a similar wildcard to the exclude lists above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones above are owned by the DevOps config and have to be in the raw path format. Unfortunately, they don't support wildcard patterns.

@Azure Azure deleted a comment from check-enforcer bot Dec 21, 2020
@jsquire
Copy link
Member Author

jsquire commented Dec 22, 2020

/check-enforcer override

@jsquire jsquire modified the milestones: MQ-2020, [2021] February Dec 31, 2020
@jsquire jsquire merged commit bb740fb into Azure:master Jan 4, 2021
@jsquire jsquire deleted the eventhubs/exclude-t1 branch January 4, 2021 22:05
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
The focus of these changes is to remove the legacy packages from the
build pipeline definitions, as they're now covered under a dedicated set
of pipeline definitions.

This is intended to allow the T1 and T2 Event Hubs packages to be treated
as separate units of work, as they will continue to evolve independently
and are maintained by different teams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants