Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Increase network timeout in tests. #17323

Merged
3 commits merged into from
Dec 4, 2020
Merged

[Storage] Increase network timeout in tests. #17323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2b6bd8
Increase network timeout in tests.
kasobol-msft Dec 4, 2020
5d783fb
why not?
kasobol-msft Dec 4, 2020
997b4d5
bump this until we have 1es agents.
kasobol-msft Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/storage/Azure.Storage.Blobs/tests/BlobTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ public BlobClientOptions GetOptions(bool parallelRange = false)
Mode = RetryMode.Exponential,
MaxRetries = Storage.Constants.MaxReliabilityRetries,
Delay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.01 : 1),
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60)
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60),
NetworkTimeout = TimeSpan.FromSeconds(200),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does NetworkTimeout apply to RecordedTestMode.Playback? If so, you might want to use a smaller value for playback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it isn't very relevant there as everything happens in memory. But why not.

},
Transport = GetTransport()
};
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/Azure.Storage.Files.DataLake/tests/DataLakeTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ public DataLakeClientOptions GetOptions(bool parallelRange = false)
Mode = RetryMode.Exponential,
MaxRetries = Constants.MaxReliabilityRetries,
Delay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.01 : 1),
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60)
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60),
NetworkTimeout = TimeSpan.FromSeconds(200),
},
Transport = GetTransport()
};
Expand Down