-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NET 5.0 testing #16947
Merged
Merged
Add NET 5.0 testing #16947
Changes from 19 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b73da0c
Add 5.0 testing
pakrym b825633
tests
pakrym f92c652
install dotnet
pakrym d289b44
builds
pakrym f521405
unit case
pakrym 0402dfc
performMultiLevelLookup
pakrym 455b5cc
DOTNET_MULTILEVEL_LOOKUP
pakrym 1555356
install step
pakrym 8c6481c
try moving comment arround
pakrym f18db1d
try moving comment arround
pakrym 2681215
2.1.x
pakrym 011abd2
fix recording path
pakrym 7f18c9d
GetDeclaredProperty
pakrym 02e6f45
fix more tests
pakrym 4b65da3
fix/disable System.Object[] autorest
pakrym 77ed34f
fix more tests
pakrym af8f31e
fix a few more
pakrym e050087
feedbacl
pakrym 23527f9
5.0
pakrym 4d9be9c
Merge remote-tracking branch 'azure/master' into pakrym/Add-5-0-testing
pakrym 549235e
Let's see if devops has 5.0
pakrym 8056354
Let's see if devops has 5.0
pakrym 290a129
fix syntax
pakrym f820645
fix some targets
pakrym b4cfe26
fix a new test
pakrym f391ef6
Merge remote-tracking branch 'azure/master' into pakrym/Add-5-0-testing
pakrym 52acc7a
fix identity build
pakrym 5dd7fbc
Disable more warnings
pakrym f58d9e0
Merge remote-tracking branch 'azure/master' into pakrym/Add-5-0-testing
pakrym 1695493
disable InheritDoc
pakrym File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ jobs: | |
displayName: 'Use Python 3.6' | ||
inputs: | ||
versionSpec: '3.6' | ||
- template: /eng/pipelines/templates/steps/install-dotnet.yml | ||
- script: >- | ||
dotnet pack eng/service.proj -warnaserror | ||
/p:ServiceDirectory=${{ parameters.ServiceDirectory }} | ||
|
@@ -44,7 +45,6 @@ jobs: | |
env: | ||
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 | ||
DOTNET_CLI_TELEMETRY_OPTOUT: 1 | ||
DOTNET_MULTILEVEL_LOOKUP: 0 | ||
- template: ../steps/archetype-sdk-docs.yml | ||
parameters: | ||
ServiceDirectory: ${{parameters.ServiceDirectory}} | ||
|
@@ -87,15 +87,15 @@ jobs: | |
inputs: | ||
versionSpec: '14.x' | ||
displayName: 'Install NodeJS' | ||
- template: /eng/pipelines/templates/steps/install-dotnet.yml | ||
- task: PowerShell@2 | ||
displayName: "Verify generated code" | ||
env: | ||
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 | ||
DOTNET_CLI_TELEMETRY_OPTOUT: 1 | ||
DOTNET_MULTILEVEL_LOOKUP: 0 | ||
inputs: | ||
filePath: "eng/scripts/CodeChecks.ps1" | ||
arguments: -ServiceDirectory ${{parameters.ServiceDirectory}} | ||
arguments: -ServiceDirectory ${{parameters.ServiceToTest}} | ||
pakrym marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pwsh: true | ||
failOnStderr: false | ||
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0 | ||
|
@@ -132,13 +132,17 @@ jobs: | |
MacOs: | ||
OSVmImage: "macOS-10.15" | ||
TestTargetFramework: netcoreapp2.1 | ||
Windows_Net50: | ||
OSVmImage: "windows-2019" | ||
TestTargetFramework: net5.0 | ||
pool: | ||
vmImage: "$(OSVmImage)" | ||
steps: | ||
- template: /eng/common/pipelines/templates/steps/verify-agent-os.yml | ||
- ${{ each step in parameters.TestSetupSteps }}: | ||
- ${{ each pair in step }}: | ||
${{ pair.key }}: ${{ pair.value }} | ||
- template: /eng/pipelines/templates/steps/install-dotnet.yml | ||
- script: >- | ||
dotnet test eng/service.proj --filter TestCategory!=Live --framework $(TestTargetFramework) | ||
--logger "trx;LogFileName=$(TestTargetFramework).trx" --logger:"console;verbosity=normal" | ||
|
@@ -149,7 +153,6 @@ jobs: | |
env: | ||
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 | ||
DOTNET_CLI_TELEMETRY_OPTOUT: 1 | ||
DOTNET_MULTILEVEL_LOOKUP: 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let dotnet host reuse existing frameworks on the machine. |
||
- task: PublishTestResults@2 | ||
condition: always() | ||
displayName: "Publish Results ($(TestTargetFramework))" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
steps: | ||
- task: UseDotNet@2 | ||
displayName: 'Use .NET Core SDK' | ||
inputs: | ||
useGlobalJson: true | ||
pakrym marked this conversation as resolved.
Show resolved
Hide resolved
|
||
performMultiLevelLookup: true | ||
- task: UseDotNet@2 | ||
condition: ne(variables['Agent.OS'], 'Windows_NT') # Windows supports MultiLevelLookup and doesn't need explicit framework installation | ||
pakrym marked this conversation as resolved.
Show resolved
Hide resolved
|
||
displayName: 'Use .NET Core 2.1 runtime' | ||
inputs: | ||
packageType: runtime | ||
version: "2.1.x" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name is somehow case sensitive now.