Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do-Not-Merge]Generated sdk for "Added application profile for VM and VMSS to specs" #16805

Closed
wants to merge 1 commit into from
Closed

[Do-Not-Merge]Generated sdk for "Added application profile for VM and VMSS to specs" #16805

wants to merge 1 commit into from

Conversation

D1v38om83r
Copy link
Contributor

Api pull request Azure/azure-rest-api-specs#11431

Do not merge, this PR is to confirm that .Net SDK code can be generated from Swagger change.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@bquantump
Copy link
Member

@D1v38om83r Please try the debug steps for the check enforcer.

@D1v38om83r
Copy link
Contributor Author

/check-enforcer reset

@D1v38om83r
Copy link
Contributor Author

/check-enforcer evaluate

@bquantump
Copy link
Member

@D1v38om83r any update on this? If we don't hear anything back, we will close this at the end of this week.

@D1v38om83r
Copy link
Contributor Author

@D1v38om83r any update on this? If we don't hear anything back, we will close this at the end of this week.

The PR was to prove that the SDK could be generated from the updated Swagger specs. The PR is not intended to be merged. We can't add the tests yet because of ARM manifest deployment issue. Can you please a some documentation on how to perform "Please try the debug steps for the check enforcer" if it is required for this PR to be considered valid?

@bquantump
Copy link
Member

@D1v38om83r

        Bhaskar Brahma
        FTE any update on this? If we don't hear anything back, we will close this at the end of this week.

The PR was to prove that the SDK could be generated from the updated Swagger specs. The PR is not intended to be merged. We can't add the tests yet because of ARM manifest deployment issue. Can you please a some documentation on how to perform "Please try the debug steps for the check enforcer" if it is required for this PR to be considered valid?

#16805 (comment)

@D1v38om83r
Copy link
Contributor Author

/check-enforcer evaluate

@D1v38om83r
Copy link
Contributor Author

/check-enforcer reset

@D1v38om83r
Copy link
Contributor Author

@D1v38om83r

        Bhaskar Brahma
        FTE any update on this? If we don't hear anything back, we will close this at the end of this week.

The PR was to prove that the SDK could be generated from the updated Swagger specs. The PR is not intended to be merged. We can't add the tests yet because of ARM manifest deployment issue. Can you please a some documentation on how to perform "Please try the debug steps for the check enforcer" if it is required for this PR to be considered valid?

#16805 (comment)

I have tried all the commands listed in that auto generated commend except for override. https://github.com/Azure/azure-sdk-for-net/pull/16805/checks?check_run_id=1482047782 doesn't lead to any logs, I only have a link to the repo for check-enforcer which has a additional command /check-enforcer reset, but that doesn't do anything either.

Where can I get the logs to debug the check-enforcer?

@bquantump
Copy link
Member

@D1v38om83r

        Bhaskar Brahma
        FTE
        Bhaskar Brahma
        FTE any update on this? If we don't hear anything back, we will close this at the end of this week.

The PR was to prove that the SDK could be generated from the updated Swagger specs. The PR is not intended to be merged. We can't add the tests yet because of ARM manifest deployment issue. Can you please a some documentation on how to perform "Please try the debug steps for the check enforcer" if it is required for this PR to be considered valid?

#16805 (comment)

I have tried all the commands listed in that auto generated commend except for override. https://github.com/Azure/azure-sdk-for-net/pull/16805/checks?check_run_id=1482047782 doesn't lead to any logs, I only have a link to the repo for check-enforcer which has a additional command /check-enforcer reset, but that doesn't do anything either.

Where can I get the logs to debug the check-enforcer?

@weshaggard

@jsquire
Copy link
Member

jsquire commented Dec 11, 2020

Hi @D1v38om83r. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out?

@jsquire jsquire added the no-recent-activity There has been no recent activity on this issue. label Dec 11, 2020
@D1v38om83r
Copy link
Contributor Author

D1v38om83r commented Dec 11, 2020

Hi @D1v38om83r. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out?

We are now adding recorded tests for the newly created SDK. It wasn't possible to record the tests earlier due to ARM manifest not being deployed.

@jsquire jsquire removed the no-recent-activity There has been no recent activity on this issue. label Dec 14, 2020
@Sandido
Copy link
Member

Sandido commented Jan 11, 2021

Swagger PR is being reverted, feature requires further development.

@Sandido Sandido closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants