Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #16440

Merged
1 commit merged into from
Oct 30, 2020
Merged

Update CODEOWNERS #16440

1 commit merged into from
Oct 30, 2020

Conversation

jamdavi
Copy link
Member

@jamdavi jamdavi commented Oct 29, 2020

Add jamdavi to IoT sdk paths for reviews

Add jamdavi to IoT sdk paths for reviews
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@ghost
Copy link

ghost commented Oct 30, 2020

Hello @jsquire!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jsquire
Copy link
Member

jsquire commented Oct 30, 2020

/check-enforcer override

@ghost ghost merged commit aaaa421 into Azure:master Oct 30, 2020
@jsquire jsquire mentioned this pull request Oct 30, 2020
AlexGhiondea added a commit to AlexGhiondea/azure-sdk-for-net that referenced this pull request Nov 3, 2020
AlexGhiondea added a commit that referenced this pull request Nov 3, 2020
* Add codeowners to the file

* Add more changes to the codeowners file.

* Re-arrange codeowners file

* Move the Management and EngSys sections to the top of the file.

* Remove angled brackets from the file to not make it look like we have merge conflicts.

* Update CODEOWNERS

added some more folders to service labels I found

* Update CODEOWNERS

Update 2 owners.

* Update CODEOWNERS

Update the ARM - Core entry to not point to Azure.Core

* Remove the extra comment around the actual entries

Doing this so that we reduce the amount of comments in the file which could lead to confusion.

* Update CODEOWNERS

Add the Event Hubs, Event Grid and Service Bus owners.

* Update CODEOWNERS

Update Event Hubs CODEOWNER

* Update CODEOWNERS

Update EventGrid.

* Update CODEOWNERS

Fix issue with the PR Label.

* Update CODEOWNERS

Incorporate #16200

* Update CODEOWNERS

Incorporate #16363

* Update CODEOWNERS

Incorporate #16440

* Update CODEOWNERS

Ensure that for WebJobs we label PRs.

* Update CODEOWNERS

Clarify the storage section.

* Update CODEOWNERS

Remove person not on the team anymore.

Co-authored-by: Meera Haridasa <22649188+meeraharidasa@users.noreply.github.com>
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Add jamdavi to IoT sdk paths for reviews
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
* Add codeowners to the file

* Add more changes to the codeowners file.

* Re-arrange codeowners file

* Move the Management and EngSys sections to the top of the file.

* Remove angled brackets from the file to not make it look like we have merge conflicts.

* Update CODEOWNERS

added some more folders to service labels I found

* Update CODEOWNERS

Update 2 owners.

* Update CODEOWNERS

Update the ARM - Core entry to not point to Azure.Core

* Remove the extra comment around the actual entries

Doing this so that we reduce the amount of comments in the file which could lead to confusion.

* Update CODEOWNERS

Add the Event Hubs, Event Grid and Service Bus owners.

* Update CODEOWNERS

Update Event Hubs CODEOWNER

* Update CODEOWNERS

Update EventGrid.

* Update CODEOWNERS

Fix issue with the PR Label.

* Update CODEOWNERS

Incorporate Azure#16200

* Update CODEOWNERS

Incorporate Azure#16363

* Update CODEOWNERS

Incorporate Azure#16440

* Update CODEOWNERS

Ensure that for WebJobs we label PRs.

* Update CODEOWNERS

Clarify the storage section.

* Update CODEOWNERS

Remove person not on the team anymore.

Co-authored-by: Meera Haridasa <22649188+meeraharidasa@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants