-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package casing issue breaking build on Linux #16014
Conversation
@nguerrera: Any idea why this is failing for you on Linux, but it seems to work for other people, it works on our Linux build agents, etc? Is there something special about your Linux distro or config? |
@mikeharder Great question and I have no idea. This is what I have:
|
Maybe something broke in a newer SDK? |
These are the errors without this patch:
|
Hmmm... I know we haven't moved our agents to ubuntu 20.04 yet and I know we had some interesting string comparison issues come on there so I suspect this might be related to that somehow. |
@nguerrera: Before you merge this, let me create a quick PR to bump our build agent to Ubuntu 20 and see if it fails there. |
Draft PR testing Ubuntu 20: #16016 |
@mikeharder Hmm that passed? Which SDK version is being used? |
https://github.com/Azure/azure-sdk-for-net/blob/master/global.json#L6 we are using 3.1.301 |
Yes, it did pass but I'm not sure what is different. Let me try on a clean Ubuntu 20.04 VM. This might be a bug in some of our custom build logic -- maybe we are comparing case-sensitive when it should be case-insensitive? This is the source of the error message but I'm not very familiar with this code: azure-sdk-for-net/eng/Microsoft.Build.CentralPackageVersions/2.0.46/Sdk/Sdk.targets Lines 170 to 173 in 4a7444b
|
I will also update my test PR to use SDK 3.1.403 (matching the original repro). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Vault and Search changes LGTM, but I echo the concern this may be a regression in the .NET toolchain (I'm not aware of other toolchains' package managers being case-sensitive).
This does look like a regression in the .NET SDK: The build passes on Ubuntu 20.04 with SDK 3.1.301, but fails on Ubuntu 20.04 with SDK 3.1.402. I'll run a few more tests to find exactly which OS/SDK versions trigger the issue. |
Also fails on Ubuntu 18.04 with SDK 3.1.402. So the Ubuntu version is not relevant. This appears to be a regression in the .NET SDK on all Ubuntu versions. |
cc @dsplaisted @nkolev92 Does this ring a bell? |
Looks like the error is coming from the CentralPackageVersions SDK. @jeffkl Also FYI @cristinamanum @anangaur |
I'm surprised, the condition that generates the error is in MSBuild and is not file system dependent. The Microsoft.Build.CentralPackageVersions SDK relies on FYI @rainersigwald |
Hi @nguerrera. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out? |
This change is part of #16947 Closing. |
@pakrym Thanks for taking care of that. I was out for a month. |
Building this repo was failing for me on Linux due to nunit vs NUnit casing.
Fixed by normalizing to NUnit, matching https://www.nuget.org/packages/NUnit/