[Event Hubs Client] Minor Improvements #15654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
christothes,
AlexGhiondea,
conniey and
serkantkaraca
|
//cc: @stewartadam, @chrisjbarr |
jsquire
force-pushed
the
eventhubs/tweaks
branch
from
f05362b
to
6c28eba
Compare
|
From our discussions this week -- for the expected delay docs, the new remarks look great and add clarity. Thank you! |
christothes
reviewed
Oct 2, 2020
sdk/eventhub/Azure.Messaging.EventHubs.Processor/src/EventProcessorClient.cs
Outdated
Show resolved
Hide resolved
christothes
approved these changes
Oct 2, 2020
The focus of these changes is to make several minor improvements, which are largely unrelated to one another. These include: - Documentation for the expected delay when stopping an Event Processor - Better documentation for client lifetimes and cachability - Additional test scenarios for the Idempotent Producer - Fixing a CODEOWNERS typo
jsquire
force-pushed
the
eventhubs/tweaks
branch
from
6c28eba
to
8b2c7e2
Compare
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
The focus of these changes is to make several minor improvements, which are largely unrelated to one another. These include: - Documentation for the expected delay when stopping an Event Processor - Better documentation for client lifetimes and cachability - Additional test scenarios for the Idempotent Producer - Fixing a CODEOWNERS typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to make several minor improvements, which are largely unrelated to one another. These include:
Last Upstream Rebase
Friday, October 3, 2:43pm (EDT)