Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14974: [BUG] DefaultAzureCredential improperly catches AuthenticationFailedException #15057

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Fix #14974: [BUG] DefaultAzureCredential improperly catches AuthenticationFailedException #15057

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b7fa0d
Fix #14974: [BUG] DefaultAzureCredential improperly catches Authentic…
AlexanderSher Sep 9, 2020
ac32caa
Check for cancellationToken
AlexanderSher Sep 10, 2020
0b72b65
- Update Changelog
AlexanderSher Sep 11, 2020
75ada30
Addressed PR comments
AlexanderSher Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check for cancellationToken
  • Loading branch information
@AlexanderSher
AlexanderSher committed Sep 10, 2020
commit ac32caad30db844b5136035e11ecd0e81101e504
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity/src/ChainedTokenCredential.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ private async ValueTask<AccessToken> GetTokenImplAsync(bool async, TokenRequestC
{
exceptions.Add(e);
}
catch (Exception e)
catch (Exception e) when (!cancellationToken.IsCancellationRequested)
{
throw new AuthenticationFailedException(AuthenticationFailedErrorMessage + e.Message, e);
}
Expand Down