-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable a way to Unregister Message Handler and Session Handler #14021
Merged
yvgopal
merged 23 commits into
Azure:master
from
DorothySun216:unregistermessagehandler
Sep 10, 2020
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8c46a41
add UnregisterMessageHandler method
DorothySun216 db9b322
Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/Core/IReceiverCl…
DorothySun216 da77a24
Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/Core/MessageRece…
DorothySun216 5e1576a
Update the unregister method to be async and await for inflight opera…
DorothySun216 61f0998
Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/SubscriptionClie…
DorothySun216 2988d02
Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/Core/MessageRece…
DorothySun216 d3faba2
Update sdk/servicebus/Microsoft.Azure.ServiceBus/src/QueueClient.cs
DorothySun216 4b921a6
Change name to have async suffix and add to existing onMessageQueueTests
DorothySun216 78aff54
Add UnregisterSessionHandlerAsync and corresponding tests
DorothySun216 25f6b8d
nit
DorothySun216 d4a5589
nit
DorothySun216 ecd820b
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net i…
DorothySun216 cd8f044
Add a new cancellation type to not cancel inflight message handling o…
DorothySun216 fff0016
Add another type of cancellation token to session handler path
DorothySun216 fae7bf1
nit
DorothySun216 642dc36
Add a timeout parameter to unregister functions and add according uni…
DorothySun216 ffc4249
nit
DorothySun216 fbd31d0
cancel runningTaskCancellationTokenSource after unregister is done
DorothySun216 f4dac4b
change public API
DorothySun216 9692122
update the API header
DorothySun216 7741ad9
update the API definition
DorothySun216 2bb96a5
fix spacing
DorothySun216 c0ec74a
fix ApproveAzureServiceBus CIT test
DorothySun216 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cancel runningTaskCancellationTokenSource after unregister is done
- Loading branch information
commit fbd31d0594772d8c8459146c32cc91106d55d0b4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest cancelling and disposing the runningTaskCancellationTokenSource here.