Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix see href links - Part 2 #13138

Merged
merged 1 commit into from
Jul 1, 2020
Merged

fix see href links - Part 2 #13138

merged 1 commit into from
Jul 1, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 1, 2020

Continuation of #12883

@maririos
Copy link
Member

maririos commented Jul 1, 2020

Changes in Text Analytics LGTM

Copy link
Member

@amnguye amnguye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in Azure.Storage.* LGTM. Thanks for these changes!

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of them look good. Thank you!

@@ -13,7 +13,7 @@ namespace Azure.Storage.Sas
/// parameters. You can construct a new instance using
/// <see cref="DataLakeSasBuilder"/>.
///
/// For more information, <see href="https://docs.microsoft.com/en-us/rest/api/storageservices/constructing-a-service-sas"/>.
/// For more information, <see href="https://docs.microsoft.com/rest/api/storageservices/create-service-sas">Create a service SAS</see>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing enough URLs that have changed that I'm concerned. Are we just 404'ing any customers who have linked or bookmarked older URLs, or are they all redirecting appropriately? This one does redirect, as have a couple others I've tried. As long as that happens, great.

@heaths heaths merged commit f64191c into Azure:master Jul 1, 2020
prmathur-microsoft pushed a commit that referenced this pull request Jul 8, 2020
@mairaw mairaw deleted the see-href2 branch August 20, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants