Fix nuget package explorer flags #13057
Conversation
chidozieononiwu
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
|
/azp run net - core - ci (Build Test Linux) |
|
No pipelines are associated with this pull request. |
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eng/Directory.Build.Data.props
Outdated
| @@ -35,6 +35,10 @@ | |||
| <AddDotnetfeedProjectSource>false</AddDotnetfeedProjectSource> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(TF_BUILD)' == 'true'"> | |||
There was a problem hiding this comment.
I don't think TF_BUILD is ever set any where. We will need to figure out the better condition.
There was a problem hiding this comment.
TF_BUILD property is actually set as a predefined variable for Azure DevOps
There was a problem hiding this comment.
OK. Do we know what exactly setting this ContinuousIntegrationBuild option ends up doing? Or why it cannot be set all the time?
There was a problem hiding this comment.
The best I can tell from here is that ContinuousIntegrationBuild property informs the SDK that it is running on the CI server which is by default deterministic. The problem I was having earlier was that it also set DeterministicSourcePaths to true which caused projects that did not reference the SourceLink package to break because SourceRoot property was not set. However for all our Shipping Client Libraries this problem is not occurring since they reference the SourceLink package.
Am not sure what else this property affects at this point except that it seems to be a recommended setting.
There was a problem hiding this comment.
Do we know if this make us green from the nuget package manager standpoint? I believe that is our primary reason for trying to make this change.
There was a problem hiding this comment.
Yes, I tested and it does make us green.
chidozieononiwu
force-pushed
the
FixNugetPackageExplorerFlags
branch
from
b235d78 to
5fc839e
Compare
Enable
ContinuousIntegrationBuildfor CI builds. This should make packages deterministic as far as Nuget Package Explorer is concerned.TF_BUILDproperty is set as a predefined variable for Azure DevOpsBump up template version since preview.15 was released for testing.