Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AutoRest C# version #13018

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Update AutoRest C# version #13018

merged 1 commit into from
Jun 25, 2020

Conversation

azure-sdk
Copy link
Collaborator

Update AutoRest C# version

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@pakrym
Copy link
Contributor

pakrym commented Jun 25, 2020

This change replaces .ToArray call with .ToList in input model constructors that allows collection to be later modified.

cc @ShivangiReja the CODEOWNERS didn't seem to work.

@ShivangiReja
Copy link
Member

@ShivangiReja the CODEOWNERS didn't seem to work.

@pakrym Strange but indentation seems little bit off, so created a PR - https://github.com/Azure/azure-sdk-for-net/pull/13023/files but I'm not sure this will fix it.

heaths
heaths approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KV and Search changes LGTM

@pakrym
Copy link
Contributor

pakrym commented Jun 25, 2020

Got shiproom approval.

@pakrym pakrym merged commit 57a30a5 into Azure:master Jun 25, 2020
prmathur-microsoft pushed a commit that referenced this pull request Jul 8, 2020
@azure-sdk @prmathur-microsoft
Update AutoRest C# version (#13018)
1ca2b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@ShivangiReja ShivangiReja ShivangiReja approved these changes

@ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@amnguye amnguye Awaiting requested review from amnguye

@arv100kri arv100kri Awaiting requested review from arv100kri

@bleroy bleroy Awaiting requested review from bleroy

@brjohnstmsft brjohnstmsft Awaiting requested review from brjohnstmsft

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

@erich-wang erich-wang Awaiting requested review from erich-wang

@isra-fel isra-fel Awaiting requested review from isra-fel

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@Kishp01 Kishp01 Awaiting requested review from Kishp01

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@schaabs schaabs Awaiting requested review from schaabs

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft

@tg-msft tg-msft Awaiting requested review from tg-msft

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azure-sdk @azuresdkci @pakrym @ShivangiReja @heaths