make track2 mgmt sdks preview 1 depends on Azure.Core 2.2 #12910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erich-wang
requested review from
amishra-dev,
amnguye,
chidozieononiwu,
danieljurek,
kasobol-msft,
mitchdenny,
seanmcc-msft,
tg-msft and
weshaggard
as code owners
erich-wang
requested review from
AlexanderSher,
AlexGhiondea,
annelo-msft,
heaths,
jsquire,
kinelski,
schaabs and
serkantkaraca
as code owners
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
reviewed
Jun 22, 2020
| @@ -3,4 +3,5 @@ | |||
| Add any shared properties you want for the projects under this package directory that need to be set before the auto imported Directory.Build.props | |||
| --> | |||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., Directory.Build.props))\Directory.Build.props" /> | |||
| <Import Condition="'$(IsMgmtClientLibrary)' == 'true'" Project="$(RepoRoot)/sdk/core/Azure.Core/src/Azure.Core.props" /> | |||
There was a problem hiding this comment.
Why add this to all the individual libraries as opposed to shared targets file?
cc @allenjzhang
prmathur-microsoft
pushed a commit
that referenced
this pull request
Jul 8, 2020
* make track2 mgmt sdks preview 1 depends on Azure.Core 2.2 * fix project reference check error * remove duplicate import for storage * fix core ci error for test common projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.