Skip to content

Conversation

@ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Jun 8, 2020

The is the beginning of a .NET SDK for the Microsoft.AVS service. I used a local swagger file that is in this pull request Azure/azure-rest-api-specs#9773 . It currently just contains the generated code. I haven't made any tests using the test framework.

@isra-fel
Copy link
Member

isra-fel commented Jun 9, 2020

Hi @ctaggart according to our guideline if you want to check in your code to master branch, the SDK must be generated from the master branch of Azure/azure-rest-api-spc , and it must be covered by tests.

@isra-fel isra-fel added Mgmt This issue is related to a management package. spec-not-merged labels Jun 9, 2020
@ctaggart
Copy link
Contributor Author

Should I change the namespace from Microsoft.Azure.Management.AVS to Microsoft.Azure.Management.Avs? Looking around the projects, it looks like I should.

Visual Studio freezes every time I try to open up either project I created and I'm not sure why. Can someone else try?

Is there something in the test base that can create and teardown a test resource group? I ask, because that is what the azdev python test API does. It is really convenient.

@ctaggart ctaggart changed the title initial Microsoft.AVS .NET SDK AVS 0.1.0 SDK Jun 10, 2020
@isra-fel
Copy link
Member

Should I change the namespace from Microsoft.Azure.Management.AVS to Microsoft.Azure.Management.Avs? Looking around the projects, it looks like I should.

Yes

Visual Studio freezes every time I try to open up either project I created and I'm not sure why. Can someone else try?

Happens to me too. Not sure why. VSCode works.

Is there something in the test base that can create and teardown a test resource group? I ask, because that is what the azdev python test API does. It is really convenient.

Common practice is to have your test project reference resource manager SDK Microsoft.Azure.Management.ResourceManager and use its client to create resource groups. E.g. https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/appplatform/Microsoft.Azure.Management.AppPlatform/tests/Tests/SpringCloudTests.cs#L34

@isra-fel
Copy link
Member

isra-fel commented Jun 11, 2020

I just added a commit to enable CI for this new module.
Please pay attention to "net - mgmt - ci" and make sure it passes.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing is, you may have noticed that our CI failed due to timeout. I have a commit checked in to master to solve the problem, so please merge or rebase master to get the fix. Thanks

@ctaggart
Copy link
Contributor Author

Thanks @isra-fel. The initial test now passes. My goal is to add test coverage that matches the az vmware tests.

@ctaggart ctaggart changed the title AVS 0.1.0 SDK AVS 1.0.0-preview.1 SDK Jun 16, 2020
@ctaggart
Copy link
Contributor Author

Hi @isra-fel, please review and merge if approved. Basic tests have been added for major functionality. I'll add more with the next API version coming up soon.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@isra-fel isra-fel merged commit 5b91ace into Azure:master Jun 22, 2020
@ctaggart ctaggart deleted the avs branch June 22, 2020 15:06
@ctaggart
Copy link
Contributor Author

Thanks for merging! How do I get this built and in the dev feed? I don't see Microsoft.Azure.Management.Avs in:
https://dev.azure.com/azure-sdk/public/_packaging?feed=azure-sdk-for-net

@isra-fel
Copy link
Member

isra-fel commented Jun 23, 2020

We have a guide here to build and publish your module to nuget.org, which is basically every dotnet SDK is doing.

I'm not familiar with dev feed, but if you are sure that's where you want your module to go, I think you can follow the same process but choose not to publish, and upload the bits to dev feed manually.

prmathur-microsoft pushed a commit that referenced this pull request Jul 8, 2020
* initial Microsoft.AVS .NET SDK

* start tests and rename part 1

* dir mv

* make test project compile

* renamed to AvsClient

* Assembly Avs

* case rename on Windows step 1

* step 2

* enable ci for avs

* first test and recorded session

* change version to 1.0.0-preview.1

Co-authored-by: Yeming Liu <felix_liu@outlook.com>

* create and delete a private cloud

* add cluster tests

Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants