Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions of Azure.Core and Azure.Core.Experimental #12520

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Update versions of Azure.Core and Azure.Core.Experimental #12520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
<PackageReference Update="ApprovalTests" Version="3.0.22" />
<PackageReference Update="ApprovalUtilities" Version="3.0.22" />
<PackageReference Update="Azure.Data.AppConfiguration" Version="1.0.0" />
<PackageReference Update="Azure.Core" Version="1.2.1" />
<PackageReference Update="Azure.Core" Version="1.2.2" />
<PackageReference Update="Azure.Core.Experimental" Version="0.1.0-preview.1" />
<PackageReference Update="Azure.Identity" Version="1.1.1" />
<PackageReference Update="Azure.Security.KeyVault.Secrets" Version="4.0.1" />
<PackageReference Update="Azure.Security.KeyVault.Certificates" Version="4.0.0" />
Expand Down
4 changes: 1 addition & 3 deletions sdk/servicebus/Azure.Messaging.ServiceBus/src/Azure.Messaging.ServiceBus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

<ItemGroup>
<PackageReference Include="Azure.Identity" />
<PackageReference Include="Azure.Core.Experimental" />
Copy link
Member

@weshaggard weshaggard Jun 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What gates do to we have in place to ensure servicebus doesn't ship with this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean GA? Nothing automatic, just our vigilance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( That scares me a little. I cannot remember but nuget might complain if you are building a GA package with a dependency on a prelease package.

<PackageReference Include="Microsoft.Azure.Amqp" />
<PackageReference Include="Microsoft.Azure.Services.AppAuthentication" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" />
Expand Down Expand Up @@ -47,9 +48,6 @@
<Compile Include="$(AzureCoreSharedSources)ValueStopwatch.cs" Link="SharedSource\Azure.Core\ValueStopwatch.cs" />

</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.Experimental\src\Azure.Core.Experimental.csproj" />
</ItemGroup>
<ItemGroup>
<Compile Update="Resources.Designer.cs">
<DesignTime>True</DesignTime>
Expand Down