Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test project for KeyVault #12228

Merged
merged 2 commits into from
May 21, 2020
Merged

Update test project for KeyVault #12228

merged 2 commits into from
May 21, 2020

Conversation

erich-wang
Copy link
Member

  1. Remove incorrect project reference Include="......\testcommon\Azure.Management.Resource.2017_05\src\Azure.Management.Resource.csproj"
  2. Test code refactor for KeyVault mgmt test project

@erich-wang erich-wang requested a review from isra-fel as a code owner May 21, 2020 06:17
isra-fel
isra-fel approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit e0d1994 into master May 21, 2020
@isra-fel isra-fel deleted the erich/mgmt.keyvault.tests branch May 21, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erich-wang @isra-fel