-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FormRecognizer] Test fix and sample reordering #11728
Conversation
/azp run net - formrecognizer - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
We worked with the other languages decide which samples to expose in what order. I don't think it make sense to change these around and realign with other languages this close to the next release. |
The agreement across languages was to leave custom before training. Users will use custom recognition more often than training. Also, we are expecting for the majority to use the Labeling Tool.
Numbering goes according to complexity in the sample. I left them with different numbers because "with forms and labels" implies that you need extra documents with the labeling format and therefore is a way more complicated scenario |
sdk/formrecognizer/Azure.AI.FormRecognizer/tests/samples/Sample4_RecognizeCustomFormsFromUri.cs
Outdated
Show resolved
Hide resolved
sdk/formrecognizer/Azure.AI.FormRecognizer/tests/samples/Sample4_RecognizeCustomFormsFromUri.cs
Outdated
Show resolved
Hide resolved
I didn't work directly with samples in the last preview, so I wasn't aware it was an agreement across languages. I'm not really fond of the |
I was thinking more about the "code complexity" than the "scenario complexity" itself, since the code of the samples are basically the same, but I don't really mind that much. I think your approach is reasonable as well. I was a bit concerned about having a while having I'll revert it back since it's not really this PR's focus. We can always discuss it again if we think it's a reason for concern. |
This reverts commit eaf1dbf.
/azp run net - formrecognizer - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - formrecognizer - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
python track2 (Azure#11728)
Set of changes:
Ignored
sample tests.FormRecognizerClientLiveTests
andFormTrainingClientLiveTests
to the new classFormRecognizerLiveTestBase
.Fixes #11493