Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing FieldBuilder.BuildForTypeRecursive returned value from a fixed Array to a List #11585

Closed
wants to merge 2 commits into from
Closed

Changing FieldBuilder.BuildForTypeRecursive returned value from a fixed Array to a List #11585

wants to merge 2 commits into from

Conversation

mhintzke
Copy link

@mhintzke mhintzke commented Apr 24, 2020 •
edited
Loading

This fixes issue #11584

@mhintzke
Changing ToArray to ToList in order to support collection mutation wh…
5b353a1 
…ich the projected return type should support
@mhintzke mhintzke changed the title Changing ToArray to ToList in order to support collection mutation wh… Changing FieldBuilder.BuildForTypeRecursive returned value from a fixed Array to a List Apr 24, 2020
@mhintzke mhintzke mentioned this pull request Apr 24, 2020
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@mhintzke
Copy link
Author

@bleroy I am working on a unit test that validates the change as well. Have confirmed it fails when using the old code and succeeds using my change

@msftclas
Copy link

msftclas commented Apr 24, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@brjohnstmsft
Copy link
Member

@mhintzke Please be advised that we are no longer maintaining Microsoft.Azure.Search and related packages, because we will be releasing a new .NET SDK package, Azure.Search.Documents, in the next few months. It's currently under active development, and will have its own equivalent of FieldBuilder.

Since we don't plan on releasing Microsoft.Azure.Search anymore, and we want to keep master in sync with the code that has shipped, we can't accept this PR.

That said, we'll take your feedback on the returned object being mutable. I'll make sure the folks working on the new FieldBuilder are aware of this.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Dec 24, 2020
CodeGen from PR 11585 in Azure/azure-rest-api-specs
5cc20ca 
Adding new api version to devops RP (Azure#11585)

* Initial commit as per PR review

* Actual changes to api spec for new version

* Switching to multi-api build for python

* Fix python spec to correct namespaces in multiapi mode

* Revert changes to python generation

* Add systemdata

* Fix the path for sys data reference

* Fix path once more

* remove additional properties after including systemdata

* Remove more addtional properties

* Move system data to root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroy bleroy bleroy approved these changes

@arv100kri arv100kri Awaiting requested review from arv100kri

@brjohnstmsft brjohnstmsft Awaiting requested review from brjohnstmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhintzke @azuresdkci @msftclas @brjohnstmsft @bleroy