[BUG] [Storage] ShareClient.DeleteIfExists throws if the Error code is ShareSnapshotNotFound

[amnguye]

Library name and version

Azure.Storage.Files.Shares

Describe the bug

When deleting a Share Snapshot using ShareClient.DeleteIfExists the call will throw an exception with ShareSnapshotNotFound. This should be included in the list of error codes.

Expected behavior

ShareClient.DeleteIfExists does not throw when seeing ShareSnapshotNotFound error code. And returns back false wrapped in the Response

Actual behavior

Throws a RequestFailedException.

Reproduction Steps

ShareClient shareClient = shareServiceClient.GetShareClient("target").WithSnapshot("2025-02-04T10:17:47.0000000Z");
shareClient.DeleteIfExists();

Environment

n/a

[amnguye]

As a mitigation, put the call within a try-catch

try
{
  ShareClient shareClient = shareServiceClient.GetShareClient("target").WithSnapshot("2025-02-04T10:17:47.0000000Z");
  shareClient.DeleteIfExists();
}
catch (RequestFailedException storageRequestFailedException)
when (storageRequestFailedException.ErrorCode == ShareErrorCode.ShareSnapshotNotFound)
{
//....
}