Skip to content

Commit

Permalink
[JobRouter] Update changelog (#40180)
Browse files Browse the repository at this point in the history
  • Loading branch information
williamzhao87 authored Nov 22, 2023
1 parent 22b2759 commit f820712
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions sdk/communication/Azure.Communication.JobRouter/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
- `UpdateExceptionPolicy(UpdateExceptionPolicyOptions options, CancellationToken cancellationToken)` changed to `UpdateExceptionPolicy(ExceptionPolicy exceptionPolicy, CancellationToken cancellationToken)`

#### RouterClient
- `GetJobs` returns `Pageable<RouterJob>` rather than `Pageable<RouterJobItem>`
- `GetWorkers` returns `Pageable<RouterWorker>` rather than `Pageable<RouterJobWorker>`
- `Pageable<RouterJobItem> GetJobs(GetJobsOptions options = null, CancellationToken cancellationToken = default)` changed to `Pageable<RouterJob> GetJobs(RouterJobStatusSelector? status = null, string queueId = null, string channelId = null, string classificationPolicyId = null, DateTimeOffset? scheduledBefore = null, DateTimeOffset? scheduledAfter = null, CancellationToken cancellationToken = default)`
- `Pageable<RouterWorkerItem> GetWorkers(GetWorkersOptions options = null, CancellationToken cancellationToken = default)` changed to `Pageable<RouterWorker> GetWorkers(RouterWorkerStateSelector? state = null, string channelId = null, string queueId = null, bool? hasCapacity = null, CancellationToken cancellationToken = default)`
- `UpdateJob(UpdateJobOptions options, CancellationToken cancellationToken)` changed to `UpdateJob(RouterJob job, CancellationToken cancellationToken)`
- `UpdateWorker(UpdateWorkerOptions options, CancellationToken cancellationToken)` changed to `UpdateWorker(RouterWorker worker, CancellationToken cancellationToken)`

Expand Down Expand Up @@ -112,6 +112,8 @@
- `UpdateQueueOptions`
- `UpdateWorkerOptions`
- `UpdateJobOptions`
- `GetJobsOptions`
- `GetWorkersOptions`

### Other Changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ internal static class CollectionExtensions
{
public static IDictionary<TK, TV?> Append<TK, TV>(this IDictionary<TK, TV?> first, IDictionary<TK, TV?> second)
{
second.ToList().ForEach(pair => first[pair.Key] = pair.Value);
return second;
second?.ToList().ForEach(pair => first[pair.Key] = pair.Value);
return first;
}

public static void AddRange<T>(this IList<T> list, IEnumerable<T> collection)
Expand Down

0 comments on commit f820712

Please sign in to comment.