Skip to content

Commit

Permalink
[Purview] Design Refactor for Scanning (#20811)
Browse files Browse the repository at this point in the history
Based on feedback with the C# architects, we've made some changes to
the class factoring here and renamed some methods. The goal was to try
to reduce the number of clients we have and clean up some naming
issues.
  • Loading branch information
ellismg authored May 3, 2021
1 parent faf936f commit d661cc7
Show file tree
Hide file tree
Showing 19 changed files with 1,452 additions and 1,651 deletions.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using Azure.Core.Pipeline;

namespace Azure.Analytics.Purview.Scanning
{
public partial class PurviewClassificationRuleClient
{
internal PurviewClassificationRuleClient(Uri endpoint, string classificationRuleName, HttpPipeline pipeline, string apiVersion) {
this.endpoint = endpoint;
this.Pipeline = pipeline;
this.classificationRuleName = classificationRuleName;
this.apiVersion = apiVersion;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using Azure.Core.Pipeline;

namespace Azure.Analytics.Purview.Scanning
{
public partial class PurviewDataSourceClient
{
internal PurviewDataSourceClient(Uri endpoint, string dataSourceName, HttpPipeline pipeline, string apiVersion) {
this.endpoint = endpoint;
this.dataSourceName= dataSourceName;
this.Pipeline = pipeline;
this.apiVersion = apiVersion;
}

/// <summary />
public PurviewScanClient GetScanClient(string scanName) => new PurviewScanClient(endpoint, dataSourceName, scanName, Pipeline, apiVersion);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using Azure.Core.Pipeline;

namespace Azure.Analytics.Purview.Scanning
{
public partial class PurviewScanClient
{
internal PurviewScanClient(Uri endpoint, string dataSourceName, string scanName, HttpPipeline pipeline, string apiVersion) {
this.endpoint = endpoint;
this.dataSourceName= dataSourceName;
this.scanName = scanName;
this.Pipeline = pipeline;
this.apiVersion = apiVersion;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

namespace Azure.Analytics.Purview.Scanning
{
public partial class PurviewScanningServiceClient
{
/// <summary />
public PurviewDataSourceClient GetDataSourceClient(string dataSourceName) => new PurviewDataSourceClient(endpoint, dataSourceName, Pipeline, apiVersion);

/// <summary />
public PurviewClassificationRuleClient GetClassificationRuleClient(string classificationRuleName) => new PurviewClassificationRuleClient(endpoint, classificationRuleName, Pipeline, apiVersion);
}
}

This file was deleted.

This file was deleted.

Loading

0 comments on commit d661cc7

Please sign in to comment.