Skip to content

Commit

Permalink
bump core version and fix errordetail reference (#23478)
Browse files Browse the repository at this point in the history
* mark test as playback only
update core version
fix errorresponse reference

* updated wrong package

* update api
  • Loading branch information
m-nash authored Aug 23, 2021
1 parent a35d8ff commit bdb87f7
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@

<!-- Packages intended for Management libraries only -->
<ItemGroup Condition="'$(IsMgmtSubLibrary)' == 'true'">
<PackageReference Update="Azure.ResourceManager" Version="1.0.0-alpha.20210730.2" />
<PackageReference Update="Azure.ResourceManager" Version="1.0.0-alpha.20210822.3" />
</ItemGroup>

<!-- Packages intended for Extensions libraries only -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public void AddPerCallPolicy()

[RecordedTest]
[SyncOnly]
[PlaybackOnly("Not intended for live tests")]
public void AddPerCallPolicyViaClient()
{
var options = InstrumentClientOptions(new ArmClientOptions());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1287,7 +1287,7 @@ protected ResourceGroupDeleteOperation() { }
public partial class ResourceGroupExportResult
{
internal ResourceGroupExportResult() { }
public Azure.ResourceManager.Resources.Models.ErrorResponse Error { get { throw null; } }
public Azure.ResourceManager.Resources.Models.ErrorDetail Error { get { throw null; } }
public object Template { get { throw null; } }
}
public partial class ResourceGroupExportTemplateOperation : Azure.Operation<Azure.ResourceManager.Resources.Models.ResourceGroupExportResult>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public partial class ResourceGroupExportResult
internal static ResourceGroupExportResult DeserializeResourceGroupExportResult(JsonElement element)
{
Optional<object> template = default;
Optional<ErrorResponse> error = default;
Optional<ErrorDetail> error = default;
foreach (var property in element.EnumerateObject())
{
if (property.NameEquals("template"))
Expand All @@ -35,7 +35,7 @@ internal static ResourceGroupExportResult DeserializeResourceGroupExportResult(J
property.ThrowNonNullablePropertyIsNull();
continue;
}
error = ErrorResponse.DeserializeErrorResponse(property.Value);
error = ErrorDetail.DeserializeErrorDetail(property.Value);
continue;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal ResourceGroupExportResult()
/// <summary> Initializes a new instance of ResourceGroupExportResult. </summary>
/// <param name="template"> The template content. </param>
/// <param name="error"> The template export error. </param>
internal ResourceGroupExportResult(object template, ErrorResponse error)
internal ResourceGroupExportResult(object template, ErrorDetail error)
{
Template = template;
Error = error;
Expand All @@ -27,6 +27,6 @@ internal ResourceGroupExportResult(object template, ErrorResponse error)
/// <summary> The template content. </summary>
public object Template { get; }
/// <summary> The template export error. </summary>
public ErrorResponse Error { get; }
public ErrorDetail Error { get; }
}
}

0 comments on commit bdb87f7

Please sign in to comment.