Skip to content

Commit

Permalink
[Storage] Increase network timeout in tests. (#17323)
Browse files Browse the repository at this point in the history
Sometimes tests experience slow transfer rate which makes tests pushing larger payloads flaky.
This is attempt to give them more time to complete transfer and see if this resolves that problem.
  • Loading branch information
kasobol-msft authored Dec 4, 2020
1 parent d4c97ea commit a987d2d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion sdk/storage/Azure.Storage.Blobs/tests/BlobTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ public BlobClientOptions GetOptions(bool parallelRange = false)
Mode = RetryMode.Exponential,
MaxRetries = Storage.Constants.MaxReliabilityRetries,
Delay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.01 : 1),
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60)
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60),
NetworkTimeout = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 100 : 200),
},
Transport = GetTransport()
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ public DataLakeClientOptions GetOptions(bool parallelRange = false)
Mode = RetryMode.Exponential,
MaxRetries = Constants.MaxReliabilityRetries,
Delay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.01 : 1),
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60)
MaxDelay = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 0.1 : 60),
NetworkTimeout = TimeSpan.FromSeconds(Mode == RecordedTestMode.Playback ? 100 : 200),
},
Transport = GetTransport()
};
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ extends:
parameters:
ServiceDirectory: storage
BuildInParallel: true
TimeoutInMinutes: 90
TimeoutInMinutes: 180
Location: canadacentral
Clouds: Preview
TestSetupSteps:
Expand Down

0 comments on commit a987d2d

Please sign in to comment.