Add fixes for AddPersonFace

Azure · Nov 18, 2022 · 53fdef2 · 53fdef2
1 parent 2a97680
commit 53fdef2
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 14 deletions.
diff --git a/sdk/cognitiveservices/Vision.Face/CHANGELOG.md b/sdk/cognitiveservices/Vision.Face/CHANGELOG.md
@@ -8,9 +8,11 @@
 
 ### Breaking Changes
 - Id fields in responses for Person and Face objects from Person Directory are no longer nullable as they are guaranteed to be returned.
+- The non-functional AddPersonFaceAsync method has been removed from Person Directory.
 
 ### Bugs Fixed
-- Fix mismatching data types between request and response for personId and persistedFaceId in Person Directory. New extension methods expecting GUIDs have been added alongside the existing string ones.
+- Fix mismatching data types between request and response for personId and persistedFaceId in Person Directory. New extension methods expecting GUIDs have been added alongside the existing string ones
+- Fix the missing parameter "url" in Person Directory AddPersonFaceAsync, which is now renamed to AddPersonFaceFromUrlAsync for clarity.
 
 ### Other Changes
 - Change default value for returnFaceId parameter to false in detection operations. 

diff --git a/sdk/cognitiveservices/Vision.Face/src/Generated/IPersonDirectory.cs b/sdk/cognitiveservices/Vision.Face/src/Generated/IPersonDirectory.cs
diff --git a/...ls/PersonDirectoryAddPersonFaceHeaders.cs → ...onDirectoryAddPersonFaceFromUrlHeaders.cs b/...ls/PersonDirectoryAddPersonFaceHeaders.cs → ...onDirectoryAddPersonFaceFromUrlHeaders.cs
diff --git a/sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectory.cs b/sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectory.cs
diff --git a/sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectoryExtensions.cs b/sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectoryExtensions.cs