Disabling Storage tests that fail occasionally during live runs (#10718)

We'd like to keep the live test runs green. Marking failures `Explicit` so they can still be run locally if desired. Tracking bugs have been filed for all of them. I'm also adding Kamil as a CODEOWNER.
Azure · Mar 19, 2020 · 42bacbe · 42bacbe
1 parent 6dd6f72
commit 42bacbe
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 35 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -37,7 +37,7 @@
 
 /sdk/servicebus/ @nemakam @jsquire
 
-/sdk/storage/ @seanmcc-msft @amnguye @tg-msft @JoshLove-msft
+/sdk/storage/ @seanmcc-msft @amnguye @kasobol-msft @tg-msft @JoshLove-msft
 
 /sdk/textanalytics/ @annelo-msft @maririos
 

diff --git a/sdk/storage/Azure.Storage.Blobs/tests/BlobClientTests.cs b/sdk/storage/Azure.Storage.Blobs/tests/BlobClientTests.cs
@@ -620,26 +620,12 @@ await UploadFileAndVerify(
 
         [Test]
         [LiveOnly]
+        [Explicit("These tests are timing out occasionally due to issue described in https://github.com/Azure/azure-sdk-for-net/issues/9340")]
         [TestCase(33 * Constants.MB, 1)]
         [TestCase(33 * Constants.MB, 4)]
         [TestCase(33 * Constants.MB, 8)]
         [TestCase(33 * Constants.MB, 16)]
         [TestCase(33 * Constants.MB, null)]
-        public async Task UploadStreamAsync_LargeBlobs(long size, int? maximumThreadCount)
-        {
-            // TODO: #6781 We don't want to add 1GB of random data in the recordings
-            await UploadStreamAndVerify(
-                size,
-                new StorageTransferOptions {
-                    MaximumConcurrency = maximumThreadCount,
-                    MaximumTransferLength = 16 * Constants.MB,
-                    InitialTransferLength = 16 * Constants.MB
-                });
-        }
-
-        [Test]
-        [LiveOnly]
-        [Explicit("These tests are timing out occasionally due to issue described in https://github.com/Azure/azure-sdk-for-net/issues/9340")]
         [TestCase(257 * Constants.MB, 1)]
         [TestCase(257 * Constants.MB, 4)]
         [TestCase(257 * Constants.MB, 8)]
@@ -650,7 +636,7 @@ await UploadStreamAndVerify(
         [TestCase(1 * Constants.GB, 8)]
         [TestCase(1 * Constants.GB, null)]
         [TestCase(1 * Constants.GB, 16)]
-        public async Task UploadStreamAsync_LargeBlobs_Explicit(long size, int? maximumThreadCount)
+        public async Task UploadStreamAsync_LargeBlobs(long size, int? maximumThreadCount)
         {
             // TODO: #6781 We don't want to add 1GB of random data in the recordings
             await UploadStreamAndVerify(
@@ -665,27 +651,12 @@ await UploadStreamAndVerify(
 
         [Test]
         [LiveOnly]
+        [Explicit("These tests are timing out occasionally due to issue described in https://github.com/Azure/azure-sdk-for-net/issues/9340")]
         [TestCase(33 * Constants.MB, 1)]
         [TestCase(33 * Constants.MB, 4)]
         [TestCase(33 * Constants.MB, 8)]
         [TestCase(33 * Constants.MB, 16)]
         [TestCase(33 * Constants.MB, null)]
-        public async Task UploadFileAsync_LargeBlobs(long size, int? maximumThreadCount)
-        {
-            // TODO: #6781 We don't want to add 1GB of random data in the recordings
-            await UploadFileAndVerify(
-                size,
-                new StorageTransferOptions
-                {
-                    MaximumConcurrency = maximumThreadCount,
-                    MaximumTransferLength = 16 * Constants.MB,
-                    InitialTransferLength = 16 * Constants.MB
-                });
-        }
-
-        [Test]
-        [LiveOnly]
-        [Explicit("These tests are timing out occasionally due to issue described in https://github.com/Azure/azure-sdk-for-net/issues/9340")]
         [TestCase(257 * Constants.MB, 1)]
         [TestCase(257 * Constants.MB, 4)]
         [TestCase(257 * Constants.MB, 8)]
@@ -696,7 +667,7 @@ await UploadFileAndVerify(
         [TestCase(1 * Constants.GB, 8)]
         [TestCase(1 * Constants.GB, null)]
         [TestCase(1 * Constants.GB, 16)]
-        public async Task UploadFileAsync_LargeBlobs_Explicit(long size, int? maximumThreadCount)
+        public async Task UploadFileAsync_LargeBlobs(long size, int? maximumThreadCount)
         {
             // TODO: #6781 We don't want to add 1GB of random data in the recordings
             await UploadFileAndVerify(
@@ -837,6 +808,7 @@ public async Task UploadAsync_OverwritesDeliberately_Path()
 
         [LiveOnly]
         [Test]
+        [Explicit("#10716 - Disabled failing UploadAsync_ProgressReporting live test")]
         public async Task UploadAsync_ProgressReporting()
         {
             // Arrange
@@ -925,6 +897,7 @@ await blob.UploadAsync(
 
         [Test]
         [LiveOnly] // Don't want a 100MB recording
+        [Explicit("#10717 - Disabled failing ChecksForCancelation live test")]
         public async Task ChecksForCancelation()
         {
             await using DisposingContainer test = await GetTestContainerAsync();

diff --git a/sdk/storage/Azure.Storage.Blobs/tests/PageBlobClientTests.cs b/sdk/storage/Azure.Storage.Blobs/tests/PageBlobClientTests.cs
@@ -1461,6 +1461,7 @@ await TestHelper.AssertExpectedExceptionAsync<RequestFailedException>(
         }
 
         [Test]
+        [Explicit("#10715 - Disabled failing StartCopyIncrementalAsync live tests")]
         public async Task StartCopyIncrementalAsync()
         {
             await using DisposingContainer test = await GetTestContainerAsync();
@@ -1530,6 +1531,7 @@ await TestHelper.AssertExpectedExceptionAsync<RequestFailedException>(
         }
 
         [Test]
+        [Explicit("#10715 - Disabled failing StartCopyIncrementalAsync live tests")]
         public async Task StartCopyIncrementalAsync_AccessConditions()
         {
             foreach (AccessConditionParameters parameters in Reduced_AccessConditions_Data)

diff --git a/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs b/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs
@@ -1924,7 +1924,7 @@ public async Task UploadAsync_SmallBlobs(int size) =>
         [TestCase(33 * Constants.MB)]
         [TestCase(257 * Constants.MB)]
         [TestCase(1 * Constants.GB)]
-        [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/9120")]
+        [Explicit("https://github.com/Azure/azure-sdk-for-net/issues/9120")]
         public async Task UploadAsync_LargeBlobs(int size) =>
             // TODO: #6781 We don't want to add 1GB of random data in the recordings
             await UploadAndVerify(size, Constants.MB);