Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormRecognier] initial merge #7996

Merged
merged 131 commits into from
Apr 8, 2020
Merged

Conversation

jeremymeng
Copy link
Contributor

This change adds track2 library for Azure Form Recognizer client.

@jeremymeng
Copy link
Contributor Author

There will be changes coming based on design discussions. However I hope to get early feedback and also fix the build.

@jeremymeng
Copy link
Contributor Author

@jeremymeng jeremymeng force-pushed the formrecognizer-t2 branch 2 times, most recently from 2edd258 to 0da453e Compare March 26, 2020 01:00
}

// @public
export type ContentType = "application/pdf" | "image/jpeg" | "image/png" | "image/tiff";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this


if (response.modelInfo.status === "ready") {
if (response.keys) {
throw new Error(`The model ${modelId} is not rained with labels.`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trained :D

* detected text, it may change across images and OCR version updates. Thus, business logic
* should be built upon the actual line location instead of order.
*/
lines?: ExtractedLine[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need this here too, if it is included in all the fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will align with the final preview.1 design.

Copy link
Contributor

@willmtemple willmtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think we can merge this as-is so we can start collaborating on this package.

@jeremymeng jeremymeng merged commit c970fb4 into Azure:master Apr 8, 2020
@jeremymeng jeremymeng deleted the formrecognizer-t2 branch April 8, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants