-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FormRecognier] initial merge #7996
Conversation
There will be changes coming based on design discussions. However I hope to get early feedback and also fix the build. |
2edd258
to
0da453e
Compare
- add trainModel.js example
the service expects full object shape
where it doesn't support multiple input content-types
bbd4e6d
to
f412b96
Compare
sdk/formrecognizer/ai-form-recognizer/samples/javascript/extractForm.js
Outdated
Show resolved
Hide resolved
sdk/formrecognizer/ai-form-recognizer/samples/javascript/extractForm.js
Outdated
Show resolved
Hide resolved
} | ||
|
||
// @public | ||
export type ContentType = "application/pdf" | "image/jpeg" | "image/png" | "image/tiff"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ this
|
||
if (response.modelInfo.status === "ready") { | ||
if (response.keys) { | ||
throw new Error(`The model ${modelId} is not rained with labels.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: trained :D
* detected text, it may change across images and OCR version updates. Thus, business logic | ||
* should be built upon the actual line location instead of order. | ||
*/ | ||
lines?: ExtractedLine[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need this here too, if it is included in all the fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will align with the final preview.1 design.
Add input content type detection Add tests
30c476f
to
6dc2d67
Compare
- Extract => Recognize - Extracted => Recognized or Form - field.name => field.fieldLabel
4c1c405
to
8801d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think we can merge this as-is so we can start collaborating on this package.
8340a86
to
d3aa9e6
Compare
This change adds track2 library for Azure Form Recognizer client.