Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] Cleanup - Moving around the devDependencies #7177

Merged
merged 1 commit into from
Jan 31, 2020
Merged

[Recorder] Cleanup - Moving around the devDependencies #7177

merged 1 commit into from
Jan 31, 2020

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Jan 31, 2020 •
edited
Loading

Moving dependencies and devDependencies around appropriately.

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder labels Jan 31, 2020
@HarshaNalluru HarshaNalluru force-pushed the harshan/issue/recorder/fix-devDependencies branch from 70e9dc3 to 8c0cd35 Compare January 31, 2020 03:14
sadasant
sadasant approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarshaNalluru HarshaNalluru merged commit 47ec537 into Azure:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasant sadasant sadasant approved these changes

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarshaNalluru @sadasant