[Common Recorder] Tests with abortSignals cause the other playback tests to be skipped #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f not running the subsequent tests when unresolved async function calls are made
HarshaNalluru
requested review from
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
added
Client
|
If the workaround looks good, I'll extend this to other storage packages and the keyvault packages too. |
XiaoningLiu
reviewed
Dec 27, 2019
| assert.equal(err.message, "The operation was aborted.", "Unexpected error caught: " + err); | ||
| } | ||
| it("Should abort after aborter timeout", function() { | ||
| async () => { |
There was a problem hiding this comment.
This is a anonymouse async method definition, but this method doesn't get executed.
There was a problem hiding this comment.
Yeah, missed it somehow 😌. Closing the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort signal issue with the recorder in the browser tests
Investigation
(I could also repro the issue with mocha in a fresh project)
NO SOLUTION SO FAR
Issue - #6297