-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Rename storage-file to storage-file-share #5734
Conversation
@KarishmaGhiya Can you review the parts related to CI and let me know if anything else needs to be done to update the existing infrastructure for |
c080275
to
9615f06
Compare
Should we add readme for the package name change? i.e. storage-file -> storage-file-share, Considering, this might be a big change user might face. |
One of the bigest PR so far. Still checking. File names, class/method/parameter names, JSDoc, documents, samples should update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI changes look good to me
@@ -77,27 +77,27 @@ There are differences between Node.js and browsers runtime. When getting started | |||
The preferred way to install the Azure File Storage client library for JavaScript is to use the npm package manager. Simply type the following into a terminal window: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still Azure File Storage client library
?
@XiaoningLiu, this PR is only to rename storage-file to storage-file-share. Classes and other names will be part of a separate PR. |
Do you mean a changelog update? |
9615f06
to
688be57
Compare
What about add some words in the readme talking about the name change? Previously we have "@azure/storage-file@next under Client: July 2019 Preview", and may be we need mention the change, besides changing @azure/storage-file@next directly to @azure/storage-file-share, otherwise it might be strange for users use @azure/storage-file@next. In reply to: 545694280 [](ancestors = 545694280) |
@jiacfan I need to check with Storage team and Scott to figure out the exact messaging we want to have here for the rename. I have logged #5769 to track this and we will get to it in the next few days. Meanwhile, this PR is the first step towards the move. Once this PR is merged, we will send another PR for the class name changes and then handle #5769 |
We can add npm package deprecate warning, so every one install @azure/storage-file will get warning to switch to @azure/storage-file-share |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally look good. Hard to view every file. Like to further review in following rename steps by Ramya.
688be57
to
bc57be5
Compare
Rebased this branch from master and re-ran all the CI tests |
As per #5705, the
storage-file
package should be renamed tostorage-file-share
.Since this involves a lot of moving parts, this PR only focuses on the rename and not the other API changes listed in #5705. They will follow after this PR is merged