Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md with global template #4211

Merged
merged 5 commits into from
Jul 9, 2019
Merged

Update readme.md with global template #4211

merged 5 commits into from
Jul 9, 2019

Conversation

bterlson
Copy link
Member

@bterlson bterlson commented Jul 8, 2019

We're working toward consistent readmes across all the language repos. This PR implements the necessary changes.

Couple interesting points:

  • I've put a new stack overflow tag in here - azure-sdk-js. The old one (azure-node-sdk) seemed possibly confusing in light of browser support landing in a number of packages.
  • I've opted NOT to document minimum requirements and getting started steps like configuring typescript - these will likely be library-specific and I don't want stale information.

We're working toward consistent readmes across all the language repos. This PR implements the necessary changes.

Couple interesting points:

* I've put a new stack overflow tag in here - azure-sdk-js. The old one (azure-node-sdk) seemed possibly confusing in light of browser support landing in a number of packages.
* I've opted NOT to document minimum requirements and getting started steps like configuring typescript - these will likely be library-specific and I don't want stale information.
@JonathanGiles JonathanGiles self-requested a review July 8, 2019 23:50
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just missing the tracking image at the bottom

@bterlson
Copy link
Member Author

bterlson commented Jul 9, 2019

/cc @ramya-rao-a can you review this quick?

README.md Outdated

- ARM based services (`@azure/arm-<serviceName>`)
- data plane SDKs like `@azure/batch`, `@azure/graph`, etc.
This repository contains official JavaScript libraries for Azure services. For documentation go to [Azure SDK for JavaScript documentation](https://aka.ms/js-docs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have had feedback from existing customers regarding the confusion between the libraries from azure-sdk-for-node repo and this one.

We can benefit from having a line here on how this repo is different from the old one and link to the migration guide.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ramya-rao-a ramya-rao-a merged commit 642d11d into master Jul 9, 2019
@KarishmaGhiya KarishmaGhiya deleted the bterlson-patch-1 branch September 23, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants