Skip to content

feature/maorleger/search 12.2.0 #36099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feature/maorleger/search 12.2.0 #36099

wants to merge 21 commits into from

Conversation

maorleger
Copy link
Member

  • initial restore
  • chore(search-documents): add .js extensions to relative imports
  • chore(search-documents): fix license header capitalization
  • generate from last stable
  • get tests partially working again, at least for some validation, since they are all skipped right now
  • wip: description and compression changes
  • implement GA features

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@github-actions github-actions bot added the Search label Oct 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/search-documents

@maorleger maorleger mentioned this pull request Oct 1, 2025
Closed
3 tasks
@maorleger maorleger requested a review from dgetu October 1, 2025 22:13
maorleger
maorleger commented Oct 3, 2025
View reviewed changes
sdk/search/search-documents/src/TROUBLESHOOTING.md Outdated

The `azure-search-documents` package provides APIs for operations on the
[Azure Cognitive Search](https://learn.microsoft.com/azure/search/search-what-is-azure-search) cloud service.
[Azure Cognitive Search](https://docs.microsoft.com/azure/search/search-what-is-azure-search) cloud service.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these changes

dgetu
dgetu approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@dgetu dgetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgetu dgetu dgetu approved these changes

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen will be requested when the pull request is marked ready for review deyaaeldeen is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng will be requested when the pull request is marked ready for review jeremymeng is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson will be requested when the pull request is marked ready for review bterlson is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maorleger @dgetu