[mgmt] recoveryservices release #36074
Conversation
kazrael2119
requested review from
qiaozha,
MaryGao,
a team and
jeremymeng
as code owners
github-actions
bot
added
the
Mgmt
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive recovery services release that appears to be a complete SDK restructure from an older code generation approach to a more modern TypeScript implementation. The purpose is to modernize the Azure Recovery Services ARM SDK with updated models, operations, and API structure.
Key changes include:
- Complete refactoring from AutoRest-generated code to a modern TypeScript client architecture
- Introduction of new model serialization/deserialization patterns
- Restructured API operations with separate classic interfaces and direct API calls
- Updated file organization with dedicated folders for different operation types
Reviewed Changes
Copilot reviewed 192 out of 224 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/operations/*.ts | Removed old AutoRest-generated operation files (usages, replicationUsages, registeredIdentities, recoveryServices, privateLinkResourcesOperations, operations, index) |
| src/models/parameters.ts | Removed old parameter definitions file |
| src/models/mappers.ts | Removed old AutoRest mapper definitions |
| src/models/models.ts | Complete rewrite with new serialization/deserialization approach and comprehensive type definitions |
| src/models/index.ts | Simplified to export only from models.js |
| src/lroImpl.ts | Removed old long-running operation implementation |
| src/logger.ts | Added new logger implementation |
| src/index.ts | Major restructure with new exports and helper functions |
| src/classic/**/*.ts | Added new classic operation interfaces |
| src/api/**/*.ts | Added new API implementation files with modern structure |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
| const res = await client.vaultExtendedInfo.get(resourceGroup, vaultsName); | ||
| assert.equal(res.type, "Microsoft.RecoveryServices/vaults/extendedInformation"); | ||
| }); | ||
|
|
||
| it("vaults delete test", async () => { | ||
| it.skip("vaults delete test", async () => { |
There was a problem hiding this comment.
@zubairabid FYi,
I called the Vaults_delete function but it failed in polling,
here's my full recording:
https://github.com/Azure/azure-sdk-assets/blob/js/recoveryservices/arm-recoveryservices_7b35b1dead/js/sdk/recoveryservices/arm-recoveryservices/recordings/node/recoveryservices_test/recording_vaults_delete_test.json
in this recording, we can see the first polling result is in progress, and the second one reports 404.
I see my resource has been deleted successfully, don't know if this is still a service issue
There was a problem hiding this comment.
We don't want to block the pr review and merge so we will skip this case for now.
https://github.com/Azure/sdk-release-request/issues/6559