Skip to content

Conversation

@jeremymeng
Copy link
Member

This PR passes PolledOperationOptions to getLongRunningPoller, allowing customers to change the interval between polls.

This PR passes PolledOperationOptions to getLongRunningPoller, allowing customers to change the interval between polls.
Copilot AI review requested due to automatic review settings July 9, 2025 20:26
@jeremymeng jeremymeng requested review from a team and bterlson as code owners July 9, 2025 20:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the load testing REST client by adding support for PolledOperationOptions to the getLongRunningPoller function, enabling customers to customize polling intervals for long-running operations.

  • Updated getLongRunningPoller function signatures to accept optional PolledOperationOptions parameter
  • Modified test files to use optimized polling intervals (0ms in playback mode, default otherwise)
  • Updated API surface documentation to reflect the new optional parameter

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/pollingHelper.ts Added PolledOperationOptions parameter to all getLongRunningPoller overloads and passes it to underlying poller functions
test/public/node/testRun.spec.ts Added test polling configuration and updated calls to use the new parameter
test/public/node/testAdministration.spec.ts Added test polling configuration and updated calls to use the new parameter
review/load-testing.api.md Updated public API documentation to reflect the new optional parameter

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure-rest/load-testing

@jeremymeng jeremymeng closed this Jul 10, 2025
@jeremymeng jeremymeng reopened this Jul 10, 2025
@jeremymeng
Copy link
Member Author

@kashish2508 @puagarwa please have a look. We should allow customers to change the polling intervals to best suit their network if needed.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Hi @jeremymeng. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 3, 2025
@jeremymeng jeremymeng removed the no-recent-activity There has been no recent activity on this issue. label Oct 3, 2025
@jeremymeng jeremymeng merged commit 6ac80a8 into Azure:main Oct 3, 2025
14 checks passed
@jeremymeng jeremymeng deleted the loadtesting/poll-options branch October 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants