-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[load-testing-rest] pass PolledOperationOptions to getLongRunningPoller #35164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR passes PolledOperationOptions to getLongRunningPoller, allowing customers to change the interval between polls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the load testing REST client by adding support for PolledOperationOptions to the getLongRunningPoller function, enabling customers to customize polling intervals for long-running operations.
- Updated
getLongRunningPollerfunction signatures to accept optionalPolledOperationOptionsparameter - Modified test files to use optimized polling intervals (0ms in playback mode, default otherwise)
- Updated API surface documentation to reflect the new optional parameter
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/pollingHelper.ts |
Added PolledOperationOptions parameter to all getLongRunningPoller overloads and passes it to underlying poller functions |
test/public/node/testRun.spec.ts |
Added test polling configuration and updated calls to use the new parameter |
test/public/node/testAdministration.spec.ts |
Added test polling configuration and updated calls to use the new parameter |
review/load-testing.api.md |
Updated public API documentation to reflect the new optional parameter |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
@kashish2508 @puagarwa please have a look. We should allow customers to change the polling intervals to best suit their network if needed. |
|
Hi @jeremymeng. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
This PR passes PolledOperationOptions to getLongRunningPoller, allowing customers to change the interval between polls.