[Storage] Fix storage-blob samples as per the api updates #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
added
Client
|
Not sure how we missed fixing these. I had to do the same in other PR as well. |
jeremymeng
reviewed
May 30, 2019
|
|
||
| // Parallel uploading with uploadFileToBlockBlob in Node.js runtime | ||
| // uploadFileToBlockBlob is only available in Node.js | ||
| await uploadFileToBlockBlob(localFilePath, blockBlobClient, { | ||
| blockSize: 4 * 1024 * 1024, // 4MB block size | ||
| parallelism: 20, // 20 concurrency | ||
| progress: ev => console.log(ev) | ||
| progress: (ev) => console.log(ev) |
There was a problem hiding this comment.
maybe disable the auto-fixing/formatting of the linting extension? that way formatting changes won't be in PRs.
There was a problem hiding this comment.
Please bear with this until @KarishmaGhiya standardizes eslint ☀
jeremymeng
approved these changes
May 30, 2019
HarshaNalluru
changed the title
The other packages seem to have |
XiaoningLiu
reviewed
May 31, 2019
| @@ -108,7 +94,7 @@ async function main() { | |||
| async function streamToString(readableStream: NodeJS.ReadableStream) { | |||
There was a problem hiding this comment.
I remembered helper methods like toStream, toStream will be integrated into SDK right? @jeremymeng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.