Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage]Bump dependency version on @azure/core-xml #31091

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[Storage]Bump dependency version on @azure/core-xml #31091

merged 2 commits into from
Sep 18, 2024

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Sep 12, 2024 •
edited by jeremymeng
Loading

No description provided.

@EmmaZhu EmmaZhu changed the title Bump dependency version on @azure/core-xml [Storage]Bump dependency version on @azure/core-xml Sep 12, 2024
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Sep 12, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

blueww
blueww approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@blueww blueww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For the only test case change , confirmed not related with the dependency upgrade, but with server behavior change.

@EmmaZhu EmmaZhu merged commit 51e1cac into main Sep 18, 2024
14 checks passed
@EmmaZhu EmmaZhu deleted the storage/upgrade_core_xml branch September 18, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@blueww blueww blueww approved these changes

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu XiaoningLiu is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang vinjiang is a code owner

@jiacfan jiacfan Awaiting requested review from jiacfan jiacfan is a code owner

@ljian3377 ljian3377 Awaiting requested review from ljian3377 ljian3377 is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaZhu @azure-sdk @blueww @jeremymeng