Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Config] Fix App Config Tests #31079

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Conversation

minhanh-phan
Copy link
Member

@minhanh-phan minhanh-phan commented Sep 11, 2024

Packages impacted by this PR

@azure/app-configuration

Issues associated with this PR

#31010

Describe the problem that is addressed by this PR

  • Move away from nock mocking because of unexpected behavior change from Node 22.7 and above.
  • Update samples to avoid duplicate key error when the samples are run in parallel

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Sep 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@minhanh-phan minhanh-phan changed the title [App Config] Fix Sync Token Tests [App Config] Fix App Config Tests Sep 16, 2024
@minhanh-phan
Copy link
Member Author

Live tests pipeline pass here

@minhanh-phan minhanh-phan marked this pull request as ready for review September 16, 2024 20:10
@minhanh-phan minhanh-phan merged commit 998eda5 into Azure:main Sep 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants