Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MQTT event handler #31072

Merged
merged 24 commits into from
Oct 1, 2024
Merged

Add support for MQTT event handler #31072

merged 24 commits into from
Oct 1, 2024

Conversation

cqnguy23
Copy link
Member

@cqnguy23 cqnguy23 commented Sep 11, 2024 •
edited
Loading

Add support for MQTT event handler

@cqnguy23 cqnguy23 changed the title Chuong/add support for mqtt event handler add support for mqtt event handler Sep 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/web-pubsub-express

@cqnguy23 cqnguy23 changed the title add support for mqtt event handler Add support for MQTT event handler Sep 12, 2024
@cqnguy23 cqnguy23 marked this pull request as ready for review September 12, 2024 04:03
vicancy
vicancy reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@vicancy vicancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, some minor comments

sdk/web-pubsub/web-pubsub-express/README.md Outdated Show resolved Hide resolved
sdk/web-pubsub/web-pubsub-express/README.md Show resolved Hide resolved
sdk/web-pubsub/web-pubsub-express/src/cloudEventsDispatcher.ts Show resolved Hide resolved
sdk/web-pubsub/web-pubsub-express/src/cloudEventsDispatcher.ts Show resolved Hide resolved
sdk/web-pubsub/web-pubsub-express/src/cloudEventsDispatcher.ts Show resolved Hide resolved
@cqnguy23 cqnguy23 force-pushed the chuong/add-support-for-mqtt-event-handler branch from c8f5658 to e27589e Compare October 1, 2024 06:47
@cqnguy23 cqnguy23 merged commit 377c46b into main Oct 1, 2024
14 checks passed
@cqnguy23 cqnguy23 deleted the chuong/add-support-for-mqtt-event-handler branch October 1, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Sindo Y-Sindo Y-Sindo approved these changes

@jeremymeng jeremymeng jeremymeng approved these changes

@vicancy vicancy vicancy approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@chenkennt chenkennt Awaiting requested review from chenkennt chenkennt is a code owner

@zackliu zackliu Awaiting requested review from zackliu zackliu is a code owner

Assignees
No one assigned
Labels
WebPubSub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cqnguy23 @azure-sdk @vicancy @jeremymeng @Y-Sindo