[notification-hubs] Moving to core-lro v3 #31002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
bterlson,
a team and
jeremymeng
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
joheredi
approved these changes
Sep 5, 2024
3 tasks
qiaozha
reviewed
Sep 6, 2024
| const abortController = new AbortController(); | ||
| const currentPollIntervalInMs = polledOperationOptions.updateIntervalInMs ?? 2000; | ||
|
|
||
| const poller: SimplePollerLike<OperationState<NotificationHubJob>, NotificationHubJob> = { | ||
| async poll(options?: { abortSignal?: AbortSignalLike }): Promise<void> { | ||
| const poller: PollerLike<OperationState<NotificationHubJob>, NotificationHubJob> = { |
There was a problem hiding this comment.
just curious why not leverage the buildCreatePoller from core-lro directly
There was a problem hiding this comment.
It's not exported at the top level of core-lro, hence why it cannot be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Moves @azure/notification-hubs to @azure/core-lro v3
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists