[web-pubsub-client's sample] Update package.json dependency from 'next' to 'latest' for azure/web-pubsub-client #30988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanthaiduong22
requested review from
vicancy,
chenkennt and
zackliu
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @phanthaiduong22! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
zackliu
approved these changes
Sep 5, 2024
qiaozha
reviewed
Sep 6, 2024
sdk/web-pubsub/web-pubsub-client/samples/v1-beta/javascript/package.json
Show resolved
Hide resolved
3 tasks
jeremymeng
approved these changes
Sep 10, 2024
|
/check-enforcer override |
|
The test failure on macos is unrelated. |
mpodwysocki
added a commit
that referenced
this pull request
Sep 11, 2024
### Packages impacted by this PR - @azure/web-pubsub-client-protobuf ### Issues associated with this PR Fixes build issues associated with #30988 ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ - #30988 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
When we run install packages for two samples (
sdk\web-pubsub\web-pubsub-client\samples\v1-beta\(javascript/typescript). We will receive error:Because there is no
nextversion ofweb-pubsub-clientpackage. So we can uselatestversionReference the version
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists