Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support operation-location final-state-via for LRO #30953

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Aug 29, 2024

fixes #30949

We should skip the final GET when the final-state-via is set as operation-location and see definition.

operation-location - poll until terminal state, skip any final GET on Location or Origin-URI and use the final response at the uri pointed to by the header Operation-Location

@MaryGao MaryGao changed the title Add the support and add test cases Support operation-location final-state-via for LRO Aug 29, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/core-lro

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as long as the REST Architecture Board is fine with the REST API definition.

@MaryGao MaryGao changed the title Support operation-location final-state-via for LRO [hold-on]Support operation-location final-state-via for LRO Aug 30, 2024
@MaryGao MaryGao changed the title [hold-on]Support operation-location final-state-via for LRO Support operation-location final-state-via for LRO Sep 4, 2024
@MaryGao
Copy link
Member Author

MaryGao commented Sep 4, 2024

Looks fine as long as the REST Architecture Board is fine with the REST API definition.

image

@MaryGao MaryGao merged commit ecff408 into Azure:main Sep 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core-lro] Support operation-location final-state-via for LRO
3 participants