Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test][data-tables] move to federated auth #30848

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

jeremymeng
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremymeng jeremymeng marked this pull request as ready for review August 22, 2024 16:45
@jeremymeng
Copy link
Member Author

CI failures are existing and known, due to new test-proxy sanitizer changes.

Copy link
Member

@minhanh-phan minhanh-phan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing to address is the version bump for "test-credential". Otherwise, the PR looks great. Thank you taking up the work 👍

sdk/tables/data-tables/package.json Outdated Show resolved Hide resolved
sdk/tables/data-tables/tests.yml Outdated Show resolved Hide resolved
@jeremymeng
Copy link
Member Author

/azp run js - data-tables - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@minhanh-phan minhanh-phan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update :shipit:

@jeremymeng
Copy link
Member Author

/check-enforcer override

@jeremymeng jeremymeng merged commit 0312603 into Azure:main Aug 22, 2024
17 of 23 checks passed
@jeremymeng jeremymeng deleted the tables/fed-auth branch August 23, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants