[eslint] fix linting issues for several packages #30826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would appear once we moved to eslint flat config. They are not detected currently likely due to incorrect configurations. - remove TextEncoder/TextDecoder declarations as they are in global scope on our supported platforms - remove --ext from linting NPM scripts - fixing issues linting README.md files - suppressing error about crypto. The feature of adding it to global scope is still experimental
jeremymeng
requested review from
FlorianBorn71,
dgetu,
a team,
xirzec,
KarishmaGhiya,
quentinRobinson,
joheredi,
timovv,
maorleger,
LarryOsterman,
deyaaeldeen,
anilba06 and
gkostal
as code owners
|
API change check API changes are not detected in this pull request. |
neither browsers nor NodeJS has a constructor parameter for TextEncoder https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder/TextEncoder https://nodejs.org/docs/latest-v18.x/api/util.html#class-utiltextencoder
deyaaeldeen
reviewed
Aug 21, 2024
deyaaeldeen
reviewed
Aug 21, 2024
|
failures in search and tables ci are known in main branch |
deyaaeldeen
approved these changes
Aug 21, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would appear once we moved to eslint flat config. They are not detected
currently likely due to incorrect configurations.
Remove TextEncoder/TextDecoder declarations as they are in global scope on our
supported platforms
Remove URL imports as they are in global scope on our supported platforms.
remove --ext from linting NPM scripts
Fix issues linting README.md files
Suppress error about crypto. The feature of adding it to global scope is still experimental
Fix build error in attestation. Neither browsers nor NodeJS has a constructor parameter for TextEncoder
https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder/TextEncoder
https://nodejs.org/docs/latest-v18.x/api/util.html#class-utiltextencoder