Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-tool] add command to type check files not being built by tshy #30810

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

jeremymeng
Copy link
Member

In our current setup, tshy won't build test and samples-dev folder even they are
included in tsconfig.json. This PR adds a command that does the type-checking
for all files included in tsconfig.json, and allow additional files to be passed
in as well.

In our current setup, tshy won't build test and samples-dev folder even they are
included in tsconfig.json.  This PR adds a command that does the type-checking
for all files included in tsconfig.json, and allow additional files to be passed
in as well.
@qiaozha
Copy link
Member

qiaozha commented Aug 21, 2024

@wanlwanl Could you also help take a look at this? Thanks

@wanlwanl
Copy link
Member

@wanlwanl Could you also help take a look at this? Thanks

@qiaozha , @MaryGao
SDK auto generation doesn't want sample & test's generation/check/run impact package building. So the sample and test related task is marked as optional, and their failures won't impact the SDK auto generation to continue.

Since this pr is creating new script, and it's not used in build script, the auto generation is not get impacted. So if the dev-tool run typecheck ... is not in build script, it'll not impact SDK auto generation

@jeremymeng
Copy link
Member Author

@mpodwysocki @timovv any other feedback?

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and thanks for this!

@jeremymeng jeremymeng merged commit 7029a9a into Azure:main Aug 27, 2024
14 checks passed
@jeremymeng jeremymeng deleted the devtool/typecheck-packages branch August 27, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants