-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-tool] add command to type check files not being built by tshy #30810
Conversation
In our current setup, tshy won't build test and samples-dev folder even they are included in tsconfig.json. This PR adds a command that does the type-checking for all files included in tsconfig.json, and allow additional files to be passed in as well.
@wanlwanl Could you also help take a look at this? Thanks |
@qiaozha , @MaryGao Since this pr is creating new script, and it's not used in |
@mpodwysocki @timovv any other feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and thanks for this!
In our current setup, tshy won't build test and samples-dev folder even they are
included in tsconfig.json. This PR adds a command that does the type-checking
for all files included in tsconfig.json, and allow additional files to be passed
in as well.