Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] fixed typos and punctuation #29225

Merged
merged 12 commits into from
Jun 25, 2024
Merged

[doc] fixed typos and punctuation #29225

merged 12 commits into from
Jun 25, 2024

Conversation

grjan7
Copy link
Contributor

@grjan7 grjan7 commented Apr 8, 2024

Fixed typos and added punctuations to improve readability of README.md files.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Thank you for your contribution @grjan7! We will review the pull request and get back to you soon.

@github-actions GitHub Actions
Copy link

Hi @grjan7. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jun 14, 2024
@grjan7 grjan7 requested a review from maorleger as a code owner June 14, 2024 05:46
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jun 14, 2024
maorleger
maorleger reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributions! I only managed to get through half the PR and left some comments. I'll review the rest sometime today. Thanks!

SUPPORT.md Outdated Show resolved Hide resolved
design/modular-development.md Outdated Show resolved Hide resolved
design/modular-development.md Outdated Show resolved Hide resolved
design/multi-client-and-multi-endpoint-in-modular.md Outdated Show resolved Hide resolved
maorleger
maorleger reviewed Jun 14, 2024
View reviewed changes
documentation/DPG-quickstart.md Outdated Show resolved Hide resolved
documentation/DPG-quickstart.md Outdated Show resolved Hide resolved
documentation/MIGRATION-guide-for-next-generation-management-libraries.md Outdated Show resolved Hide resolved
documentation/Quickstart-on-how-to-write-tests.md Outdated Show resolved Hide resolved
documentation/Quickstart-on-how-to-write-tests.md Outdated Show resolved Hide resolved
documentation/Quickstart-on-how-to-write-tests.md Outdated Show resolved Hide resolved
documentation/Quickstart-on-how-to-write-tests.md Outdated Show resolved Hide resolved
maorleger
maorleger reviewed Jun 14, 2024
View reviewed changes
documentation/Bundling.md Outdated Show resolved Hide resolved
documentation/Bundling.md Outdated Show resolved Hide resolved
documentation/Bundling.md Outdated Show resolved Hide resolved
documentation/Bundling.md Outdated Show resolved Hide resolved
documentation/Bundling.md Outdated Show resolved Hide resolved
documentation/Bundling.md Outdated Show resolved Hide resolved
documentation/next-generation-quickstart.md Outdated Show resolved Hide resolved
documentation/next-generation-quickstart.md Outdated Show resolved Hide resolved
documentation/steps-after-generations.md Outdated Show resolved Hide resolved
documentation/steps-after-generations.md Outdated Show resolved Hide resolved
@grjan7
Copy link
Contributor Author

grjan7 commented Jun 14, 2024

Thank you for the contributions! I only managed to get through half the PR and left some comments. I'll review the rest sometime today. Thanks!

Thanks for your comments. I'll go through them.

grjan7 and others added 5 commits June 15, 2024 00:34
@grjan7 @maorleger
Update design/multi-client-and-multi-endpoint-in-modular.md
5c80c3a 
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
@grjan7 @maorleger
Apply suggestions from code review
12c4516 
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
@grjan7 @maorleger
Update documentation/Quickstart-on-how-to-write-tests.md
37e56e6 
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
@grjan7 @maorleger
Apply suggestions from code review
f3aeff9 
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
@grjan7
docs: revert formatting
3227854
maorleger
maorleger approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thank you for the contribution!

In the future, please consider submitting smaller PRs - perhaps one PR per 1-3 files. Larger PRs are harder to review and can delay getting changes merged.

@maorleger
Copy link
Member

/check-enforcer override

@maorleger maorleger merged commit e6db98e into Azure:main Jun 25, 2024
4 checks passed
@grjan7
Copy link
Contributor Author

grjan7 commented Jun 25, 2024

Changes look great, thank you for the contribution!

You're welcome!

@grjan7
Copy link
Contributor Author

grjan7 commented Jun 25, 2024

In the future, please consider submitting smaller PRs - perhaps one PR per 1-3 files. Larger PRs are harder to review and can delay getting changes merged.

Noted. Thanks for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maorleger maorleger maorleger approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grjan7 @maorleger